Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FIX): put padding so the text is not clipped #5305

Merged
merged 9 commits into from
Oct 24, 2023
Merged

(FIX): put padding so the text is not clipped #5305

merged 9 commits into from
Oct 24, 2023

Conversation

dobri1408
Copy link
Contributor

BEFORE:
Captură de ecran din 2023-10-11 la 10 14 36

AFTER:
Captură de ecran din 2023-10-11 la 10 13 20

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for volto ready!

Name Link
🔨 Latest commit 755c0ec
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6532b0751bb4fb0008bdd2c6
😎 Deploy Preview https://deploy-preview-5305--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dobri1408 dobri1408 mentioned this pull request Oct 12, 2023
Merged
@ichim-david ichim-david self-requested a review October 12, 2023 15:07
ichim-david
ichim-david requested changes Oct 12, 2023
View reviewed changes
src/components/manage/Blocks/Search/components/SelectStyling.jsx Outdated
@@ -32,6 +32,7 @@ export const customSelectStyles = {
valueContainer: (styles) => ({
...styles,
padding: '0px',
paddingTop: '4px',
paddingLeft: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobri1408 this is redundant given that at line 34 you have padding 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobri1408 this doesn't fix the fact that you can also have bottom text clipping when you use p or g
see the screenshot
4px-2-rows-demo

@dobri1408
Copy link
Contributor Author

I made sure that the padding is right now. I have put an 8 px padding on all sides.

@dobri1408 dobri1408 requested a review from ichim-david October 12, 2023 16:06
@dobri1408
Copy link
Contributor Author

I think the best solution is to increase the height of the container as the rows of the content are growing. Because the problem is now shifted to a text of 3 lines, instead of two. I will try to approach this solution.

@ichim-david
Copy link
Member

I think the best solution is to increase the height of the container as the rows of the content are growing. Because the problem is now shifted to a text of 3 lines, instead of two. I will try to approach this solution.

I've seen that this fixes only 2 lines but you also have to think that it is a placeholder text, at some point, you have to keep it simple enough to be easily translatable and useful, I doubt that someone will use 3 lines of placeholder text.

@ichim-david ichim-david requested a review from sneridagh October 23, 2023 13:31
@sneridagh sneridagh merged commit f97f331 into main Oct 24, 2023
@sneridagh sneridagh deleted the padding-select-facet branch October 24, 2023 14:21
sneridagh added a commit that referenced this pull request Oct 25, 2023
@sneridagh
Merge branch 'main' into registryinownpackage
7af83d7 
* main: (38 commits)
  A11y - Updated aria-labels for landmarks, added landmark for sidebar and plug skiplinks (#5290)
  (FIX): put padding so the text is not clipped (#5305)
  Add upgrade docs for users of `@kitconcept/volto-blocks-grid` addon (#5333)
  Add new multilingual acceptance tests with Seamless mode enabled (#5332)
  Fix reference to installation (#5328)
  Fix compare translations view (#5327)
  Release 17.2.0
  Fix to return correct results when loading the search block from a URL (#5298)
  Allow multiple path criteria (#5317)
  Release 17.1.1
  Added guard in `flattenScales` in edge case image is undefined (#5318)
  Normalize the shape of the image component `item` prop if it contains the serialized object after creation to match the one in the catalog. (#5266)
  Release 17.1.0
  move the function to get the lead image sizes to the block configuration (#5289)
  Removed default aspect-ratio from Image component (#5278)
  Added support for `blocksConfig` configuration in the listing block (#5310)
  fix: logo and login storybook (#5286)
  Refactor Logo component to improve the conditional link to the root (#5280)
  Fix hierarchy of readme headings
  Clean up readme and install docs (#5287)
  ...
sneridagh pushed a commit that referenced this pull request Oct 27, 2023
@dobri1408 @ichim-david @sneridagh
(FIX): put padding so the text is not clipped (#5305)
6758138 
Co-authored-by: ichim-david <ichim.david@gmail.com>
sneridagh added a commit that referenced this pull request Oct 30, 2023
@sneridagh
Merge branch 'main' into slate_upgrade_09
204a322 
* main: (283 commits)
  Release 17.3.0
  Fix DatetimeWidget on FF, the button default if no type is set is sen… (#5343)
  Call applyBlockDefaults from addBlock/insertBlock, add initialValue() configuration option for blocks (#5320)
  A11y - Updated aria-labels for landmarks, added landmark for sidebar and plug skiplinks (#5290)
  (FIX): put padding so the text is not clipped (#5305)
  Add upgrade docs for users of `@kitconcept/volto-blocks-grid` addon (#5333)
  Add new multilingual acceptance tests with Seamless mode enabled (#5332)
  Fix reference to installation (#5328)
  Fix compare translations view (#5327)
  Release 17.2.0
  Fix to return correct results when loading the search block from a URL (#5298)
  Allow multiple path criteria (#5317)
  Release 17.1.1
  Added guard in `flattenScales` in edge case image is undefined (#5318)
  Normalize the shape of the image component `item` prop if it contains the serialized object after creation to match the one in the catalog. (#5266)
  Release 17.1.0
  move the function to get the lead image sizes to the block configuration (#5289)
  Removed default aspect-ratio from Image component (#5278)
  Added support for `blocksConfig` configuration in the listing block (#5310)
  fix: logo and login storybook (#5286)
  ...
sneridagh added a commit that referenced this pull request Oct 30, 2023
@sneridagh
Merge branch 'main' into upgrade_slate
4522e88 
* main:
  Release 17.3.0
  Fix DatetimeWidget on FF, the button default if no type is set is sen… (#5343)
  Call applyBlockDefaults from addBlock/insertBlock, add initialValue() configuration option for blocks (#5320)
  A11y - Updated aria-labels for landmarks, added landmark for sidebar and plug skiplinks (#5290)
  (FIX): put padding so the text is not clipped (#5305)
  Add upgrade docs for users of `@kitconcept/volto-blocks-grid` addon (#5333)
  Add new multilingual acceptance tests with Seamless mode enabled (#5332)
  Fix reference to installation (#5328)
  Fix compare translations view (#5327)
  Release 17.2.0
  Fix to return correct results when loading the search block from a URL (#5298)
  Allow multiple path criteria (#5317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichim-david ichim-david ichim-david approved these changes

@sneridagh sneridagh sneridagh approved these changes

Assignees
No one assigned
Labels
01 type: bug 24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dobri1408 @ichim-david @sneridagh