Refactor Logo component to improve the conditional link to the root #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
tiberiuichim
approved these changes
Oct 7, 2023
erral
approved these changes
Oct 7, 2023
sneridagh
added a commit
that referenced
this pull request
Oct 11, 2023
* main: Release 17.1.0 move the function to get the lead image sizes to the block configuration (#5289) Removed default aspect-ratio from Image component (#5278) Added support for `blocksConfig` configuration in the listing block (#5310) fix: logo and login storybook (#5286) Refactor Logo component to improve the conditional link to the root (#5280) Fix hierarchy of readme headings Clean up readme and install docs (#5287) Add note in release notes for Volto 17 final (#5281) Update webpack-bundle-analyzer (#5283) Upgrade @plone/scripts to 3.0.1 (#5282) Release @plone/scripts 3.0.1 Update translate pt-br label_my_email_is (#5217) Emit a proper URL for the Plone root in a listing (#5263) Storybook Header (#5085) Fix error: no such file or directory, open 'addon-testing-project/jsconfig.json' in addon clone command (#5245) Ensure .gitignore gets copied when running `yo @plone/volto-addon` (#5258) Make prettier checks .js in root and cypress folder (#5260)
sneridagh
added a commit
that referenced
this pull request
Oct 25, 2023
* main: (38 commits) A11y - Updated aria-labels for landmarks, added landmark for sidebar and plug skiplinks (#5290) (FIX): put padding so the text is not clipped (#5305) Add upgrade docs for users of `@kitconcept/volto-blocks-grid` addon (#5333) Add new multilingual acceptance tests with Seamless mode enabled (#5332) Fix reference to installation (#5328) Fix compare translations view (#5327) Release 17.2.0 Fix to return correct results when loading the search block from a URL (#5298) Allow multiple path criteria (#5317) Release 17.1.1 Added guard in `flattenScales` in edge case image is undefined (#5318) Normalize the shape of the image component `item` prop if it contains the serialized object after creation to match the one in the catalog. (#5266) Release 17.1.0 move the function to get the lead image sizes to the block configuration (#5289) Removed default aspect-ratio from Image component (#5278) Added support for `blocksConfig` configuration in the listing block (#5310) fix: logo and login storybook (#5286) Refactor Logo component to improve the conditional link to the root (#5280) Fix hierarchy of readme headings Clean up readme and install docs (#5287) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up what we said during the Volto Team Meeting, it's better to not rely in
toPublicURL, and do not rely on the router sync in Redux store. I changed all to use pathnames, and fallback to/if an error is found and no info is in the store.