Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in release notes for Volto 17 final #5281

Merged
merged 8 commits into from
Oct 7, 2023
Merged

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Oct 6, 2023

@ksuess I've figured out what happened: The PR started just before we did the transition to Towncrier, then the change log info was in CHANGELOG.md so it did made to the wrong place, then towncrier didn't pick it up.

Sorry about it!

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit f99d89c
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/652117f32f69ed000862fe9c

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some gramma and incorporate @davisagli's suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
davisagli and others added 3 commits October 7, 2023 09:27
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
news/5281.documentation Outdated Show resolved Hide resolved
news/5281.documentation Outdated Show resolved Hide resolved
sneridagh and others added 2 commits October 7, 2023 10:33
@sneridagh sneridagh merged commit 51864b6 into main Oct 7, 2023
48 of 49 checks passed
@sneridagh sneridagh deleted the addnotein17final branch October 7, 2023 08:34
sneridagh added a commit that referenced this pull request Oct 11, 2023
* main:
  Release 17.1.0
  move the function to get the lead image sizes to the block configuration (#5289)
  Removed default aspect-ratio from Image component (#5278)
  Added support for `blocksConfig` configuration in the listing block (#5310)
  fix: logo and login storybook (#5286)
  Refactor Logo component to improve the conditional link to the root (#5280)
  Fix hierarchy of readme headings
  Clean up readme and install docs (#5287)
  Add note in release notes for Volto 17 final (#5281)
  Update webpack-bundle-analyzer (#5283)
  Upgrade @plone/scripts to 3.0.1 (#5282)
  Release @plone/scripts 3.0.1
  Update translate pt-br label_my_email_is (#5217)
  Emit a proper URL for the Plone root in a listing (#5263)
  Storybook Header (#5085)
  Fix error: no such file or directory, open 'addon-testing-project/jsconfig.json' in addon clone command (#5245)
  Ensure .gitignore gets copied when running `yo @plone/volto-addon` (#5258)
  Make prettier checks .js in root and cypress folder (#5260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants