Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Management Notes #5358

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Release Management Notes #5358

merged 11 commits into from
Feb 26, 2024

Conversation

sneridagh
Copy link
Member

Definition of breaking

@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 731e9ba
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65dc65844058520008bd0937

stevepiercy
stevepiercy requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spelling, grammar, syntax, and style guide improvements.

docs/source/release-management-notes/index.md Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
@sneridagh sneridagh mentioned this pull request Nov 14, 2023
Merged
sneridagh and others added 2 commits November 15, 2023 08:50
stevepiercy
stevepiercy approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once merged, I would add reference links to it from the PRs:

@stevepiercy
Copy link
Collaborator

This file needs to be reconciled against the file RELEASING.md in the root of the Volto repo or monorepo before merging. See also #5409

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 731e9ba
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65dc6584b1b201000881ab3f

@sneridagh sneridagh marked this pull request as ready for review February 21, 2024 10:27
@sneridagh
Copy link
Member Author

@tisto @mauritsvanrees It's been a while I've started to write this. What do you think? We can merge this, and continue iterating over it, but I think it's good enough for now.

mauritsvanrees
mauritsvanrees approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

One small suggestion on improving the wording.

docs/source/release-management-notes/index.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

Should there be references to the following, explaining how all these documents complement one another?

@sneridagh @mauritsvanrees
Update docs/source/release-management-notes/index.md
baa0306 
Co-authored-by: Maurits van Rees <maurits@vanrees.org>
@sneridagh
Copy link
Member Author

@stevepiercy I don't think that the first one needs to reference here.

I guess that it makes sense to have it in: https://plone.org/download/release-schedule

@mauritsvanrees what do you think?

@mauritsvanrees
Copy link
Member

@stevepiercy I don't think that the first one needs to reference here.

Agreed.

I guess that it makes sense to have it in: https://plone.org/download/release-schedule

Adding a link to the release schedule/policy would indeed be good. Probably in the paragraph directly under the main 'Release management notes'

stevepiercy
stevepiercy requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a suggested phrase and admonition for the link.

docs/source/release-management-notes/index.md Show resolved Hide resolved
stevepiercy
stevepiercy approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with some grammar fixes, MyST enhancements, and cross-reference linking.

sneridagh
sneridagh commented Feb 26, 2024
View reviewed changes
docs/source/release-management-notes/index.md Outdated

Any change to a control panel.
Any change to a control panel is a breaking change.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy It's not, since it's CMSUI. All these examples are changes that would normally be declared as breaking following the public API directives, but it won't because its private API.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 2fcdcc9

@sneridagh
Copy link
Member Author

@stevepiercy LGTM! I would merge it right away, I have ack from Timo too.

@stevepiercy
Copy link
Collaborator

Added changelog.

We can ignore the failing readme-link-check for now, to give the site owner a chance to respond.

@stevepiercy stevepiercy merged commit 351da33 into main Feb 26, 2024
64 of 65 checks passed
@stevepiercy stevepiercy deleted the releasenotesbreakingchange branch February 26, 2024 10:43
sneridagh added a commit that referenced this pull request Feb 28, 2024
@sneridagh
Merge branch 'main' into react18
cdedc2f 
* main: (43 commits)
  5645 toolbar buttons toggle when clicking same toolbar button (#5795)
  fix: array widget sort (#5805)
  Fix a11y logo issue (#5776)
  Improve Vite PoC - Add BlockRenderer and `@plone/blocks` to the party (#5798)
  Removed memori websites that give 404 since they are no longer using Volto (#5803)
  Release Management Notes (#5358)
  Enhance findBlocks to check for blocks in data for add-ons (#5797)
  Release @plone/components 2.0.0-alpha.2
  Move basic default CSS out of theme. Improve StoryBook intro page (#5791)
  Switch peerDependencies to Volto 18 for generator-volto alpha's/latest. (#5781)
  Release 18.0.0-alpha.13
  Release @plone/slate 18.0.0-alpha.7
  Fix sidebar form update. (#5779)
  Add uncommited types for release??
  Release 18.0.0-alpha.12
  Add accordion to metadata form. (#5760)
  Release @plone/registry 1.3.1
  [registry] Export Config type as ConfigType, amend coresandbox (#5774)
  Release @plone/components 2.0.0-alpha.1
  Add import path for compiled CSS (#5770)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@tisto tisto Awaiting requested review from tisto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneridagh @stevepiercy @mauritsvanrees