Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed querystring search query type #6034

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

pnicolli
Copy link
Contributor

@pnicolli pnicolli commented May 20, 2024

Current query validation is

const query = z.object({
  i: z.string(),
  o: z.string(),
  v: z.array(z.string()),
});

But at least one index (SearchableText), but I assume many, actually require a literal string as v instead of an array of strings.

Yes this could be a lot more specific, this could specify the right v type for each index or something similar, but before embarking on that journey I think we can start simple and just allow plain strings.


📚 Documentation preview 📚: https://volto--6034.org.readthedocs.build/

@pnicolli pnicolli requested a review from sneridagh May 20, 2024 21:38
Copy link

netlify bot commented May 20, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit e693af1
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/664f47b2fbd56a00080b8dc4

@davisagli davisagli merged commit 1fa4a90 into main May 23, 2024
70 checks passed
@davisagli davisagli deleted the fix-querystring-search-type branch May 23, 2024 14:26
sneridagh added a commit that referenced this pull request May 30, 2024
* main: (60 commits)
  Object browser icon view v2 (#6054)
  Refactor TextWidget (#6020)
  [client] Remove the custom runner with bare vitest config (#6056)
  [client] Fix login mutation (#6053)
  Fix test script in monorepo root (#6051)
  Fix block chooser search is not focusable when clicked on add button (#5867)
  [@plone/types] BlockExtension as Interface types (#6049)
  Fixed querystring search query type (#6034)
  Id widget refactor (#6027)
  Release 18.0.0-alpha.32
  Release @plone/providers 1.0.0-alpha.1
  Release @plone/components 2.0.0-alpha.9
  Release @plone/client 1.0.0-alpha.15
  Release @plone/types 1.0.0-alpha.13
  Fix @plone/client deps (#6045)
  Allow X-Robots-Tag header in images/files middleware (#6043)
  Fixed showRestricted not applying when rendering a custom BlocksForm (#6026)
  change relative import to alias import (#6041)
  Build documentation and Storybook only when their files change (#6037)
  Use pnpm corepack instead of installing it in CI (#6038)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants