Use pnpm corepack instead of installing it in CI #6038
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
These changes LGTM. However:
- it needs a change log
- these steps need to align with the changes, too: https://github.com/plone/volto/blob/main/.readthedocs.yaml#L19-L20
See error log detail: https://readthedocs.org/projects/volto/builds/24443014/
|
@stevepiercy done! |
|
@sneridagh RTD still no like: https://readthedocs.org/projects/volto/builds/24443126/. I'm not sure how to resolve this one. I was using https://6.docs.plone.org/volto/contributing/developing-core.html#pnpm as a guide. Maybe we need to install Node.js first, even though it is declared in https://github.com/plone/volto/pull/6038/files#diff-03efc769b870804394632e45d7885272b44c16939517fb31c9d7c614d2ffae57R13, so don't need to use nvm? Sorry my JS install knowledge is novice. |
|
@stevepiercy depends on how node is installed in that image... :( do we know more about the image they are using? maybe we can install a package. |
|
@sneridagh here's what I found, which is not very helpful. https://dev.readthedocs.io/en/latest/design/build-images.html |
|
Still failing: https://readthedocs.org/projects/volto/builds/24443350/ |
|
@stevepiercy it should work now. However, it seems that GHA have a hickup now |
* main: (60 commits) Object browser icon view v2 (#6054) Refactor TextWidget (#6020) [client] Remove the custom runner with bare vitest config (#6056) [client] Fix login mutation (#6053) Fix test script in monorepo root (#6051) Fix block chooser search is not focusable when clicked on add button (#5867) [@plone/types] BlockExtension as Interface types (#6049) Fixed querystring search query type (#6034) Id widget refactor (#6027) Release 18.0.0-alpha.32 Release @plone/providers 1.0.0-alpha.1 Release @plone/components 2.0.0-alpha.9 Release @plone/client 1.0.0-alpha.15 Release @plone/types 1.0.0-alpha.13 Fix @plone/client deps (#6045) Allow X-Robots-Tag header in images/files middleware (#6043) Fixed showRestricted not applying when rendering a custom BlocksForm (#6026) change relative import to alias import (#6041) Build documentation and Storybook only when their files change (#6037) Use pnpm corepack instead of installing it in CI (#6038) ...
📚 Documentation preview 📚: https://volto--6038.org.readthedocs.build/