Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm corepack instead of installing it in CI #6038

Merged
merged 6 commits into from
May 21, 2024
Merged

Use pnpm corepack instead of installing it in CI #6038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
802ef3e
Enable corepack instead of installing it
sneridagh May 21, 2024
e1eb47f
Changelog
sneridagh May 21, 2024
0a78184
Add corepack to the storybook build in RTD
sneridagh May 21, 2024
55b9f60
Try to make happy RTD
sneridagh May 21, 2024
208f8b5
Try to make happy RTD 2
sneridagh May 21, 2024
8a372d9
Try to make happy RTD 3
sneridagh May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 28 additions & 72 deletions .github/workflows/acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
# We don't want to install until later,
# when the cache and Cypress are in place
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -103,11 +98,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -185,11 +177,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -267,11 +256,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -349,11 +335,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -431,11 +414,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -512,11 +492,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -594,11 +571,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -676,11 +650,8 @@ jobs:
# with:
# node-version: ${{ matrix.node-version }}

# - uses: pnpm/action-setup@v3
# name: Install pnpm
# with:
# version: 9
# run_install: false
# - name: Enable corepack
# run: corepack enable

# - name: Get pnpm store directory
# shell: bash
Expand Down Expand Up @@ -747,11 +718,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -830,11 +798,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -940,11 +905,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -1081,11 +1043,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -1165,11 +1124,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down
28 changes: 8 additions & 20 deletions .github/workflows/code-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -55,11 +52,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -95,11 +89,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -135,11 +126,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down
27 changes: 6 additions & 21 deletions .github/workflows/deployment_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
# We don't want to install until later,
# when the cache and Cypress are in place
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -88,13 +83,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
# We don't want to install until later,
# when the cache and Cypress are in place
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -155,13 +145,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
# We don't want to install until later,
# when the cache and Cypress are in place
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down
35 changes: 10 additions & 25 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -72,11 +69,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -113,11 +107,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -148,11 +139,8 @@ jobs:
with:
node-version: ${{ env.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down Expand Up @@ -191,11 +179,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 9
run_install: false
- name: Enable corepack
run: corepack enable

- name: Get pnpm store directory
shell: bash
Expand Down
4 changes: 3 additions & 1 deletion .readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ build:
# Install dependencies defined in your ``package.json``
# - npm ci
# Install any other extra dependencies to build the docs
- npm install -g pnpm@latest
- corepack enable
- corepack prepare pnpm@* --activate
- asdf reshim nodejs
- pnpm install
- pnpm build:registry
- (cd packages/volto && pnpm build-storybook -o ${READTHEDOCS_OUTPUT}/html/storybook)
Expand Down
1 change: 1 addition & 0 deletions packages/volto/news/6038.internal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use pnpm corepack instead of installing it in CI @sneridagh
Loading