Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slots] @plone/slots first developments #6409

Merged
merged 79 commits into from
Dec 11, 2024
Merged

[slots] @plone/slots first developments #6409

merged 79 commits into from
Dec 11, 2024

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Oct 15, 2024

Third level strategic package experiments

First developments on the @plone/slots, @plone/blocks, and @plone/theming packages.
Put it all together, for having sound app shells.
Updated RR7 and REMIX apps, using them.
Components now are CSS layered and moved RenderBlocks to @plone/blocks.

First trials on the shape as a not transpiled, not Volto add-on package to make it work-able as a node_modules package, and compatible with Next.js, vite-based frameworks and ultimately, Volto compatible too, just in case they are necessary there. In order to make it work, this kind of packages must not be under src directory. Let's not fight the ecosystem anymore in this matter. If the package is not being transpiled, the direct resolution must work OOTB, so the bundlers resolution is direct, and the TypeScript resolution too.

sneridagh and others added 18 commits June 5, 2024 08:28
* main: (31 commits)
  Release 18.0.0-alpha.35
  Release @plone/types 1.0.0-alpha.16
  (fix): export getFieldURL from Url.js in helpers (#6100)
  Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099)
  Support nested directories in public folder add-on sync folders both … (#6098)
  Release 18.0.0-alpha.34
  Add generated new declarations for a34, just in case (#6097)
  Release @plone/slate 18.0.0-alpha.13
  Release @plone/registry 1.6.0
  Release @plone/types 1.0.0-alpha.15
  Add support for reading the add-ons `tsconfig.json` paths (#6096)
  Fixes #6046 pass proper defaults to align and size fields of Image block (#6093)
  bug fix. relations control panel. Restrict eglible relation targets a… (#6092)
  Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088)
  Add optional `token` parameter to ploneClient initialization (#6077)
  Blocks Layout Navigator (#5642)
  Fix internalUrl  Widget to Reflect Prop Changes via onChangeBlock (#6036)
  [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095)
  Fix link in pop-up RelationsMatrix.jsx (#6085)
  Fix deselecting lists. (#6080)
  ...
Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>
* main: (185 commits)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
  Release 18.0.0-alpha.46
  Release @plone/components 2.0.0-alpha.14
  Add missing export for new components (#6391)
  Revert "Fix block chooser search is not focusable when clicked on add button" (#6390)
  Replace unhelpful words with helpful ones (#6386)
  Added missing improvement to the build-deps Makefile command (#6383)
  Added rule for ESlint to detect missing key property in iterators. (#6387)
  Fix syntax of `html_meta` under `myst` field. (#6385)
  Release 18.0.0-alpha.45
  Release @plone/components 2.0.0-alpha.13
  Release @plone/types 1.0.0-alpha.20
  Add chapter: theming a base theme (#6328)
  Upgrade vite to latest (#6373)
  Porting a few minor fixes upstream (#6382)
  Added missing arg for `buildStyleClassNamesExtenders` (#6381)
  Remove pin on Vale, and upgrade to v3.x configuration (#6376)
  Change formatting from blob of text to definition list. (#6378)
  ...
* main:
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
@sneridagh sneridagh requested a review from pnicolli October 15, 2024 20:23
sneridagh and others added 9 commits October 16, 2024 09:13
Co-authored-by: Steve Piercy <web@stevepiercy.com>
* main:
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
Co-authored-by: Steve Piercy <web@stevepiercy.com>
* main:
  Release 18.1.1
  Release @plone/providers 1.0.0-alpha.6
  Release @plone/components 2.2.0
  [components] Update RAC to 1.5.0, fix Disclosure import (#6498)
  Update instructions to install pipx in `RELEASING.md` (#6496)
  Refactor documentation includes to align with main documentation pattern (#6495)
  More privacy concerning youtube links and fixing link check warnings for youtube playlist links (#6494)
  fix: BodyClass depending on sections (#6487)
  Do not break toolbar if layout id is not registerd in layoutViewsNamesMapping (#6485)
  Add support for sphinxcontrib-youtube and alt tags for videos (#6486)
  Remove conflicting searchtools.js file for documentation (#6482)
  Release 18.1.0
  Release @plone/slate 18.0.1
  Add missing style Helmet serialization in the HTML component to make it work in SSR too (#6480)
  fix locales
  Dutch Translations update.  (#6476)
  Docs 6472 tidy (#6475)
* main:
  Release 18.1.2
  Remove devserver settings for HMR of volto (#6511)
  Release @plone/components 2.2.1
  [components] Fix color picker usability (#6512)
  Fix README in npm by copying it from the root of the monorepo. (#6510)
  Add Accessibility acceptance tests for content-types (#6339)
  Fix linkcheck (#6502)
  Update browserslist (#6501)
  Add new Volto trainings to tutorials (#6499)
* main:
  Commit missing README from release
  Release 18.2.0
  Release @plone/slate 18.0.2
  Removed all imports from barrel files for components, actions, helpers, hooks and lodash (#6509)
@sneridagh sneridagh marked this pull request as ready for review December 8, 2024 09:49
@sneridagh
Copy link
Member Author

@pnicolli @stevepiercy please take a final look and give me your ack.
It seems huge, but it's all about experimental packages and apps and all the work that Piero and me did for the PC preparation.
Let's merge it to have the latest of the latest in main, so we can continue.
Piero, let me know when your other PR is ready, and we can re-enable the NextJS app tests and merge yours.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor grammar fixes.

packages/theming/README.md Outdated Show resolved Hide resolved
packages/components/news/6409.breaking Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

@sneridagh I need a little context.

Is this PR a breaking change in Volto 18 by moving blocks from src into an npm package @plone/blocks? If yes, then should we cut an 18.x.x branch before merging this to main, and designate main as future Volto 19?

Are all @plone/blocks, @plone/theming, and @plone/slots still experimental?

@sneridagh
Copy link
Member Author

@stevepiercy we are not breaking anything (yet), don't worry. This is all about the experiments in the API-first story, and won't happen into Volto until Plone 7. So not even for 19. With this PR, Volto is untouched, and will continue using the "in-Volto" components.

19 will be the last version "as Volto used to be", no hard breakings.

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy
Copy link
Collaborator

@sneridagh the news fragment packages/components/news/6409.breaking made me wonder whether it is breaking.

@sneridagh
Copy link
Member Author

@plone/components is not "core" yet (and won't be anytime soon), at least for our mental sanity.

@sneridagh sneridagh merged commit 5df5443 into main Dec 11, 2024
72 checks passed
@sneridagh sneridagh deleted the slots-base branch December 11, 2024 17:39
sneridagh added a commit that referenced this pull request Dec 12, 2024
* main:
  Fixed types declaration extractor from Volto core, re-enable it on release (#6534)
  Release 18.3.0
  Release @plone/slate 18.0.4
  Release @plone/helpers 1.0.0
  Make helpers release-able
  Release @plone/registry 2.2.0
  Release @plone/components 3.0.0
  Release @plone/types 1.1.0
  [slots] @plone/slots first developments (#6409)
  improve link integrity popup (#6516)
  Add missing styleWrapper style builder information in container/Grid (#6527)
  update: skip scroll to top on inital SSR completion. (#6523)
  Release 18.2.3
  Fixed circular import error in dev with HMR in core Views and Widgets shadow customizations (#6526)
  Release 18.2.2
  Fixed circular import error in dev with HMR in core Blocks shadow customizations (#6525)
  Release 18.2.1
  Release @plone/slate 18.0.3
  Fixed circular import error in dev with HMR in `App` component when imported in the main default config (#6524)
  Update @plone/* packages info (#6521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants