DuckDB version fix (#883)

* DuckDB version * changelog * Empty-Commit * Pin pandas * Pin pandas * Facet order * Img renamed * questdb images * changelog
ploomber · Sep 19, 2023 · cf824ca · cf824ca
1 parent 6494461
commit cf824ca
Show file tree

Hide file tree

Showing 19 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 * [Fix] Fix result not displayed when `SUMMARIZE` argument is used in duckdb with a sqlalchemy connection (#836)
 * [Fix] Show deprecation warnings for legacy plot API (#513)
 * [Fix] Fix error when trying to access previously non-existing file (#840)
+* [Fix] Testing with latest DuckDB version (#498)
 
 ## 0.10.1 (2023-08-30)
 

diff --git a/setup.py b/setup.py
@@ -33,14 +33,14 @@
 DEV = [
     "flake8",
     "pytest",
-    "pandas",
+    "pandas==2.0.3",
     "polars==0.17.2",  # 04/18/23 this breaks our CI
     "pyarrow",
     "invoke",
     "pkgmt",
     "twine",
     # tests
-    "duckdb<0.8.0",
+    "duckdb",
     "duckdb-engine",
     "pyodbc",
     # sql.plot module tests

diff --git a/src/sql/ggplot/facet_wrap.py b/src/sql/ggplot/facet_wrap.py
@@ -17,6 +17,7 @@ def get_facet_values(self, table, column, with_):
             SELECT
             distinct ({{column}})
             FROM {{table}}
+            ORDER BY {{column}}
             """
         )
         query = template.render(table=table, column=column)
@@ -25,6 +26,7 @@ def get_facet_values(self, table, column, with_):
         # Added to make histogram more inclusive to NULLs
         # Filter out NULL values
         # If value[0] is NULL we skip it
+
         values = [value for value in values if value[0] is not None]
         n_plots = len(values)
         n_cols = len(values) if len(values) < 3 else 3

diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_custom_fill.png b/src/tests/baseline_images/test_ggplot/facet_wrap_custom_fill.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_custom_fill_and_color.png b/src/tests/baseline_images/test_ggplot/facet_wrap_custom_fill_and_color.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_custom_stacked_histogram.png b/src/tests/baseline_images/test_ggplot/facet_wrap_custom_stacked_histogram.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_custom_stacked_histogram_cmap.png b/src/tests/baseline_images/test_ggplot/facet_wrap_custom_stacked_histogram_cmap.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_default.png b/src/tests/baseline_images/test_ggplot/facet_wrap_default.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_default_no_legend.png b/src/tests/baseline_images/test_ggplot/facet_wrap_default_no_legend.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_default_with_nulls.png b/src/tests/baseline_images/test_ggplot/facet_wrap_default_with_nulls.png
diff --git a/src/tests/baseline_images/test_ggplot/facet_wrap_nulls_data.png b/src/tests/baseline_images/test_ggplot/facet_wrap_nulls_data.png
diff --git a/src/tests/baseline_images/test_ggplot/test_facet_wrap_default_with_nulls.png b/src/tests/baseline_images/test_ggplot/test_facet_wrap_default_with_nulls.png
diff --git a/src/tests/integration/baseline_images/test_questDB/facet_wrap_custom_fill.png b/src/tests/integration/baseline_images/test_questDB/facet_wrap_custom_fill.png
diff --git a/...s/integration/baseline_images/test_questDB/facet_wrap_custom_fill_and_color.png b/...s/integration/baseline_images/test_questDB/facet_wrap_custom_fill_and_color.png
diff --git a/...ntegration/baseline_images/test_questDB/facet_wrap_custom_stacked_histogram.png b/...ntegration/baseline_images/test_questDB/facet_wrap_custom_stacked_histogram.png
diff --git a/...ation/baseline_images/test_questDB/facet_wrap_custom_stacked_histogram_cmap.png b/...ation/baseline_images/test_questDB/facet_wrap_custom_stacked_histogram_cmap.png
diff --git a/src/tests/integration/baseline_images/test_questDB/facet_wrap_default.png b/src/tests/integration/baseline_images/test_questDB/facet_wrap_default.png
diff --git a/...tests/integration/baseline_images/test_questDB/facet_wrap_default_no_legend.png b/...tests/integration/baseline_images/test_questDB/facet_wrap_default_no_legend.png
diff --git a/src/tests/test_ggplot.py b/src/tests/test_ggplot.py
@@ -431,7 +431,7 @@ def test_facet_wrap_stacked_histogram_cmap(diamonds_data):
 
 @_cleanup_cm()
 @image_comparison(
-    baseline_images=["test_facet_wrap_default_with_nulls"],
+    baseline_images=["facet_wrap_default_with_nulls"],
     extensions=["png"],
     remove_text=False,
 )