forked from catherinedevlin/ipython-sql
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opengraph improvements #685
Closed
anupam-tiwari
wants to merge
118
commits into
ploomber:master
from
anupam-tiwari:opengraph-improvements
Closed
Changes from 84 commits
Commits
Show all changes
118 commits
Select commit
Hold shift + click to select a range
3dd5ec3
Empty-Commit
9df6b3f
changelog
ad8cc22
title
45fa429
link image
5f06143
removed image
496fb92
added image
03c6ae8
Merge branch 'ploomber:master' into opengraph-improvements
anupam-tiwari 1373cab
local file test
c8af7e9
image change
8939465
image
70b0b93
image
be18433
image 2
e52aab3
img3
28bba32
testing static image
4ce7fef
static
6b826f8
added alt image
702575c
comma
bf2270b
test alt
265990b
added alt text
4e5051e
added extension
69d2fd8
resolved conflict
13bc716
added url
e6c0381
import error
c505fd5
error
b5ea78f
resolve error
549174d
test
248fbbb
added link
a84ca33
removed slash
0811d69
removed typo
f301281
added files
1c09baf
added img
b760914
added file
1460b07
Empty-Commit
ec8a264
Empty-Commit
3eed54c
commit
d6137cf
commit
0ba3a39
commit
5cc0258
commit
3e6e3d7
Merge branch 'ploomber:master' into master
anupam-tiwari 4925947
Merge branch 'ploomber:master' into master
anupam-tiwari 0ff160d
Merge branch 'ploomber:master' into master
anupam-tiwari 0e497db
Merge branch 'ploomber:master' into master
anupam-tiwari d6a0985
commit
c188c66
commit
9ebfd08
commit
fcdbd8e
commit
ba1bd90
commit
9530d8f
commit
483d28b
commit
611f0a5
commit
913bd12
Merge branch 'ploomber:master' into master
anupam-tiwari e9fa4da
commit
0b4963d
commit
efbc459
commit
388cbc7
commit
4998879
commit
78fc75f
commit
847130c
commit
3a251c9
commit
cc15f75
Merge branch 'ploomber:master' into master
anupam-tiwari 9153b59
commit
3389e5a
commit
33b0de1
commit
584c709
commit
e22089b
commit
37bc212
commit
9d88696
commit
f686191
commit
e5aa10f
commit
25eb0cc
commit
73244db
commit
e9f2cbd
Merge branch 'ploomber:master' into master
anupam-tiwari df49c84
Empty-Commit
d152cfc
Merge branch 'ploomber:master' into master
anupam-tiwari 37c6fee
commit
14354c4
commit
1c2963f
commit
e3a37f6
commit
f9e8109
commit
d99e756
commit
bb04fed
commit
a5602af
commit
054bbc0
commit
33fd15d
updated based on review
9315d2d
Merge branch 'ploomber:master' into master
anupam-tiwari 8e7056e
merging
0cbc64e
created drawio folder called asset folder
2990c22
testing og:image:alt
c70b090
lint/format
c57fad1
Merge branch 'ploomber:master' into master
anupam-tiwari 1efe85f
added og:image:alt
b36a43c
Merge branch 'ploomber:master' into master
anupam-tiwari 0977b26
conflict
1e43716
Merge branch 'ploomber:master' into master
anupam-tiwari 3cafc11
Merge branch 'ploomber:master' into master
anupam-tiwari e4eb068
conflict
f12c355
Merge branch 'ploomber:master' into master
anupam-tiwari 4e44524
conflict
8d275cd
exp
1aefd17
exp
ef5a7a1
null title
f9f9b1b
doc
272a9da
doc
cc092b4
doc
c38adf0
doc
e74f4ec
Merge branch 'ploomber:master' into master
anupam-tiwari 3903870
conflict
1ba63e0
Merge branch 'ploomber:master' into master
anupam-tiwari 28e9057
conflict
e23548a
test
74cc883
test
97d3ca0
test
80ce25a
test
09cf684
Merge branch 'ploomber:master' into master
anupam-tiwari 0ff9d04
confict
8c51c39
Merge branch 'ploomber:master' into master
anupam-tiwari d0b5e80
Merge branch 'ploomber:master' into master
anupam-tiwari 6849aae
conflict
anupam-tiwari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this and the other image are duplicated, do we need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't need that, I was wondering where should i save the drawio files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a drawio file, this is a png file. so if we don't need it, let's delete it
for the drawio files, check if we already have an existing drawio file and put it there, if we don't you can create a folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a folder for that, I'll create one in doc folder!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created folder with drawio files!