-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opengraph improvements #685
Opengraph improvements #685
Conversation
@edublancas can you please check if this is the req! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this looks right!
the only missing item is:
- check if it's possible to display one image by default (in case a given article doesn't have one)
example: given your changes, duckdb's section shows a preview image: https://www.opengraph.xyz/url/https%3A%2F%2Fjupysql--685.org.readthedocs.build%2Fen%2F685%2Fintegrations%2Fduckdb.html but all other sections don't show anything: https://www.opengraph.xyz/url/https%3A%2F%2Fjupysql--685.org.readthedocs.build%2Fen%2F685%2Fintro.html so we want to show a default image so something always shows up while we add custom ones per section |
|
@edublancas I tried checking if image can be a static image but I couldn't find a way out, I think image link is the only way, please let me know if there is some other way! |
@anupam-tiwari check merge conflicts |
remember to explicitly request a review when this is ready |
yes! this is not yet ready |
|
hey @anupam-tiwari: I'm going to close this now, no need to keep working on it |
Describe your changes
Tasks
Issue number
Closes #253
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--685.org.readthedocs.build/en/685/