Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckDB version fix #883

Merged
merged 9 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* [Fix] Fix result not displayed when `SUMMARIZE` argument is used in duckdb with a sqlalchemy connection (#836)
* [Fix] Show deprecation warnings for legacy plot API (#513)
* [Fix] Fix error when trying to access previously non-existing file (#840)
* [Fix] Testing with latest DuckDB version (#498)

## 0.10.1 (2023-08-30)

Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@
DEV = [
"flake8",
"pytest",
"pandas",
"pandas==2.0.3",
edublancas marked this conversation as resolved.
Show resolved Hide resolved
"polars==0.17.2", # 04/18/23 this breaks our CI
"pyarrow",
"invoke",
"pkgmt",
"twine",
# tests
"duckdb<0.8.0",
"duckdb",
"duckdb-engine",
"pyodbc",
# sql.plot module tests
"matplotlib",
"matplotlib==3.7.2",
"black",
# for %%sql --interact
"ipywidgets",
Expand Down
2 changes: 2 additions & 0 deletions src/sql/ggplot/facet_wrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ def get_facet_values(self, table, column, with_):
SELECT
distinct ({{column}})
FROM {{table}}
ORDER BY {{column}}
"""
)
query = template.render(table=table, column=column)
Expand All @@ -25,6 +26,7 @@ def get_facet_values(self, table, column, with_):
# Added to make histogram more inclusive to NULLs
# Filter out NULL values
# If value[0] is NULL we skip it

values = [value for value in values if value[0] is not None]
n_plots = len(values)
n_cols = len(values) if len(values) < 3 else 3
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/tests/baseline_images/test_ggplot/facet_wrap_default.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/tests/baseline_images/test_ggplot/facet_wrap_nulls_data.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/tests/test_ggplot.py
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def test_facet_wrap_stacked_histogram_cmap(diamonds_data):

@_cleanup_cm()
@image_comparison(
baseline_images=["test_facet_wrap_default_with_nulls"],
baseline_images=["facet_wrap_default_with_nulls"],
edublancas marked this conversation as resolved.
Show resolved Hide resolved
extensions=["png"],
remove_text=False,
)
Expand Down
Loading