Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Filter nil values before triggering initial layout callbacks. #81

Closed
wants to merge 2 commits into from

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Sep 20, 2018

This get rid of the initial None callbacks, during my investigation (plotly/dash#396), I found that the None callbacks were blocking more useful callbacks.

We would need to update all the docs that does this:

@app(Output('output', 'children'), [Input('btn', 'n_clicks')])
def on_clicks(n_clicks):
    if n_clicks is None:
        raise PreventUpdate

@chriddyp
Copy link
Member

I'm hesitant to do this right now as it would be a breaking change. I think that I'd like to combine a set of breaking changes together as part of a greater 2.0 release that we could more easily document and inform our community about.

For example, if we changed this behaviour, then we could introduce the Ryan's "components with defaults" PRs (plotly/dash-core-components#234) among other features.

Perhaps we should create a 2.0 master issue to document all of these breaking changes that we could / would like to do in the next version. Similar to plotly.js's 2.0 issue: plotly/plotly.js#420

@ned2 ned2 added the dash 2.0 For issues involving changes potentially slated for Dash 2.0 label Sep 23, 2018
@T4rk1n T4rk1n changed the base branch from master to 1.0.0-release December 13, 2018 20:09
@T4rk1n T4rk1n closed this Feb 26, 2019
@T4rk1n T4rk1n deleted the remove-none-callbacks branch February 26, 2019 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash 2.0 For issues involving changes potentially slated for Dash 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants