Add private field to track DASH_APP_NAME
#173
Conversation
rpkyle
added
enhancement
parity
DESCRIPTION
Outdated
| Imports: | ||
| dashHtmlComponents (== 1.0.2), | ||
| dashCoreComponents (== 1.6.0), | ||
| dashCoreComponents (== 1.7.0), |
There was a problem hiding this comment.
| dashCoreComponents (== 1.7.0), | |
| dashCoreComponents (>= 1.7.0), |
Probably best to change this to greater than, as 1.8.0 of dash-core-components has been released to master.
R/dash.R
Outdated
| assertthat::assert_that(is.logical(suppress_callback_exceptions)) | ||
|
|
||
| # save relevant args as private fields | ||
| if (is.null(name) && Sys.getenv("DASH_APP_NAME") != "") { |
There was a problem hiding this comment.
Hi Ryan,
I checked out the code and it looks good; the implementation follows the Python version as much as it makes sense to, and the logic is sound. I tested it out locally and with a deployed app on Dash Enterprise, and it was able to locate the DASH_APP_NAME env. variable and assign that as the name.
Only change I made was allowing newer versions of dashCoreComponents, or installation of the package fails unless a user downgrades to the exact version specified in the description. We may even want to change this for the other dependencies, it would make it easier to transition from working locally with different versions of dash and component packages.
💃
rpkyle
changed the title
rpkyle
changed the title
DASH_APP_NAME
|
The relevant changes were applied in #165, thus resolving https://github.com/plotly/streambed/issues/14081. Closing this one. |
This PR will add a private field to track the
DASH_APP_NAMEwhen set via the environment.Closes plotly/streambed#14081.
@alexcjohnson @Marc-Andre-Rivet