Merge pull request #4688 from plotly/rangebreaks-missing-gridlines

Avoid missing gridlines on axis with rangebreaks using "day of week" pattern
plotly · Mar 25, 2020 · 7c67896 · 7c67896
2 parents 60425d2 + 3daa0a5
commit 7c67896
Show file tree

Hide file tree

Showing 4 changed files with 2,143 additions and 0 deletions.
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -807,6 +807,12 @@ axes.autoTicks = function(ax, roughDTick) {
             ax.dtick = 'M' + roundDTick(roughDTick, 1, roundBase24);
         } else if(roughX2 > ONEDAY) {
             ax.dtick = roundDTick(roughDTick, ONEDAY, roundDays);
+
+            if(ax._hasDayOfWeekBreaks) {
+                if(ax.dtick === 2 * ONEDAY) ax.dtick = ONEDAY;
+                else if(ax.dtick === 3 * ONEDAY) ax.dtick = 7 * ONEDAY;
+            }
+
             // get week ticks on sunday
             // this will also move the base tick off 2000-01-01 if dtick is
             // 2 or 3 days... but that's a weird enough case that we'll ignore it.

diff --git a/src/plots/cartesian/axis_defaults.js b/src/plots/cartesian/axis_defaults.js
@@ -135,6 +135,13 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
         if(!containerOut.rangebreaks.length) {
             delete containerOut.rangebreaks;
         } else {
+            for(var k = 0; k < containerOut.rangebreaks.length; k++) {
+                if(containerOut.rangebreaks[k].pattern === DAY_OF_WEEK) {
+                    containerOut._hasDayOfWeekBreaks = true;
+                    break;
+                }
+            }
+
             setConvert(containerOut, layoutOut);
 
             if(layoutOut._has('scattergl') || layoutOut._has('splom')) {

diff --git a/test/image/baselines/axes_breaks-round-weekdays.png b/test/image/baselines/axes_breaks-round-weekdays.png