Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid missing gridlines on axis with rangebreaks using "day of week" pattern #4688

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 25, 2020

Follow up of #4614,
This PR fixes #4686 | demo: before vs after

@plotly/plotly_js

- round 2 days to 1 day
- round 3 days to 7 days
@archmoj archmoj added bug something broken status: reviewable labels Mar 25, 2020
@archmoj archmoj added this to the v1.53.0 milestone Mar 25, 2020
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing grid lines and tick labels with range breaks at daily level
2 participants