Skip to content

Cone traces with irregular grids do not scale cone correctly #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etpinard opened this issue Jun 6, 2018 · 2 comments
Closed

Cone traces with irregular grids do not scale cone correctly #2701

etpinard opened this issue Jun 6, 2018 · 2 comments
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

etpinard commented Jun 6, 2018

See https://codepen.io/etpinard/pen/gKMJyZ that has the default sizemode and sizeref and compare with https://codepen.io/etpinard/pen/eKzawB?editors=0010 that has sizeref: 10. Cone should always be visible using the default sizeref so something is off.

I believe this is (another) side-effect of our dataScale hack (more on that in: #2646) where sizeref: 1 should correspond to two cones of max norm at the minimal adjacent position just touching each other. But by the time gl-cone3d computes the max length the x/y/z positions and u/v/w vectors are scaled meaning that we should also scale sizeref before passing it to gl-cone3d. Doing this might be tricky as x/y/z and u/v/w are vectors and sizeref is a scalar, but hopefully there's a way to do so in plotly.js.

If so, fixing this should also fix #2700

@etpinard etpinard added the bug something broken label Jun 6, 2018
@etpinard
Copy link
Contributor Author

etpinard commented Jun 6, 2018

by irregular I mean grids that generate unequal x-axis, y-axis, z-axis ranges.

@etpinard
Copy link
Contributor Author

Closed in #2715 (for now at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

1 participant