-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Promise polyfill #1758
Remove Promise polyfill #1758
Conversation
Note that tests were failing before I made any changes. |
Thanks for the PR. But, we can't just do that. Dropping support for Promise-less browsers will have to wait until Like I said in #955 (comment), we could publish a a |
@etpinard I understand, but it's been a while since #955 has been opened and I thought I should give it a try and remove the polyfill. As I explained in the issue, users should not be forced to use a polyfill if they don't want to and it should be up to them to provide the necessary APIs that plotly would require. Anyhow, I also understand that breaking compatibility is not an option. So making an extra bundle does not sound like a bad idea. How should I approach that, because I'm not familiar with the build system for this lib? |
@etpinard why not just avoid polluting of global scope with your polyfill? I understand you want promises and you need polyfill, I've just wondering why you made graphing library export anything but graphing. |
That's a good idea. That might still be considered a breaking change, but it's worth investigating. Anyone down to submit a PR?
People make mistakes. Sorry. I should add:
|
@etpinard I'd give it a shot at making another bundle without polyfills, but I need to understand how the bundles are created. |
It starts here: https://github.com/plotly/plotly.js/blob/master/tasks/bundle.js Learning a few things about the browserify api first might help. |
Understood. I've rebuilt it as stated in #955. Sorry I can't help with PR - I'm not familiar with Plotly code. |
This addresses #955. It basically just removes
es6-promise
polyfill as there is really no need for it unless you use a legacy browser.I've also added some doc on this matter for users that do still use legacy browsers.