Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image testing with image-exporter electron runner #1972

Closed
wants to merge 5 commits into from

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Aug 28, 2017

... or in other words, bye bye old image server and (hopefully) bye bye imagetest docker container.

To try this out:

What's new:

  • electron based testing using image-exporter runner app
  • no http requests are made, the runner app reads the JSON mocks directly from your file system
  • a pure node-js image comparison routine using Mapbox's pixelmatch and pngjs. That means bye-bye gm and imageMagick

Results:

  • much faster test runs. On my machine, npm run test-image runs in under 1:30 minute (N.B. that's over 400 mocks folks)
  • Should work consistently across all machines.

TODO:

  • if this works out well for everyone, delete:
    • all imagetest related things in tasks
    • test/image/assets/get_image_request_options.js

- no more making requests to the image server in the imagetest
  docker container
- we now _just_ need to run the image-exporter runner app with
  the correct input and write functions.
@etpinard
Copy link
Contributor Author

etpinard commented May 4, 2018

Moved to #2615

@etpinard etpinard closed this May 4, 2018
@etpinard etpinard deleted the image-exporter branch May 4, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant