Image testing with image-exporter electron runner
#1972
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or in other words, bye bye old image server and (hopefully) bye bye
imagetestdocker container.To try this out:
image-exporterin the plotly.js package.json)npm inpm run baselineandnpm run test-imagenpm run test-exportbut this one needs plotly-graph PDF with electron's printToPDF orca#6 to work properly.What's new:
electronbased testing usingimage-exporterrunner apppixelmatchandpngjs. That means bye-byegmandimageMagickResults:
npm run test-imageruns in under 1:30 minute (N.B. that's over 400 mocks folks)TODO:
imagetestrelated things intaskstest/image/assets/get_image_request_options.js