Bump mapbox gl to 0.44.0 #2361

etpinard · 2018-02-12T23:01:51Z

resolves #1714 and makes #2029 obsolete.

It's about time we do this. Note that mapbox-gl@0.44.0 is still incompatible with nw@0.12 that we use in our imagetest container (ref #2029 (comment)), meaning we'll have to manually test mapbox subplot image generation. But yeah after some discussing with @jackparmer, this is way better than sticking to a almost two year old version of mapbox-gl.

A lot of things have changed from mapbox-gl version 0.22.0 to 0.44.0. Our tests did catch many of those changes. But still, we'll need to manually test this thing thoroughly before merging.

This PR also adds support for (un)selected marker size and color on top of marker opacity for scattermapbox traces #2346, fixes a hover bug and improves first-render performance.

Some TODOs:

thorough manual testing
write more convert test for selected / unselected attributes - done in 1998f90

... mostly to hide mapbox-gl's own no-css warning that get injected into the DOM.

... to scattermapbox traces, along with fixing existing bugs and cleaning up the convert logic (in 0.44.0, we no longer have to generate a hacky hash stops array 🎉

- by setting up paint and layout props during the 1st addLayer call and by setting up the source during the 1st addSource call, as opposed to having an blank 'init' and a generic 'update' step.

jackparmer · 2018-02-12T23:27:13Z

Happy to manually test this tonight or tomorrow on stage!

alexcjohnson · 2018-02-12T23:52:41Z

meaning we'll have to manually test mapbox subplot image generation.

What do you mean by this? Just that we have tests that can't run on CI but can run locally, or are there things we have to run in a browser and eyeball?

etpinard · 2018-02-13T14:27:26Z

What do you mean by this? Just that we have tests that can't run on CI but can run locally, or are there things we have to run in a browser and eyeball?

I added a command in tasks/noci_test.sh that re-generates the mapbox baselines using image-exporter. If this doesn't generate a git diff we're good. We could use something more evolved at some point, depending how long we'll have to wait before merging #1972.

- see #2343 (comment) for more details on this issue.

etpinard · 2018-02-13T21:12:12Z

After some testing help from @jackparmer, tagging this thing as reviewable.

alexcjohnson · 2018-02-13T21:58:10Z

test/jasmine/tests/scattermapbox_test.js

-            expect(evt.clientX).toEqual(pointPos[0], 'event.clientX');
-            expect(evt.clientY).toEqual(pointPos[1], 'event.clientY');
+            expect(evt.clientX).toBeDefined('event.clientX');
+            expect(evt.clientY).toBeDefined('event.clientY');


why did these have to change?

Oops. My mistake. I shouldn't have committed this. Good 👁️ Reverted in 0ef2ba6

alexcjohnson · 2018-02-13T22:15:25Z

test/image/mocks/mapbox_bubbles.json

@@ -46,6 +46,29 @@
          "opacity": 0.5


Looks (from the baseline image change) like this didn't actually work before, but now it does 🎉
Was that a known bug?

Yes (after some initial confusion) -> #2346

alexcjohnson · 2018-02-13T22:22:46Z

src/traces/scattermapbox/hover.js


    // shift longitude to [-180, 180] to determine closest point
    var lonShift = winding * 360;
    var xval2 = xval - lonShift;

+    function wrapLon(lon) {
+        return Lib.wrap180(lon);
+    }


this wrapper seems unnecessary

alexcjohnson · 2018-02-14T02:27:17Z

src/components/drawing/index.js

@@ -439,8 +439,8 @@ drawing.pointStyle = function(s, trace, gd) {
    });
 };

-drawing.selectedPointStyle = function(s, trace) {
-    if(!s.size() || !trace.selectedpoints) return;
+drawing.makeSelectedPointStyleFns = function(trace) {


Nice abstraction here 👌

alexcjohnson · 2018-02-14T02:31:50Z

@etpinard this looks great! We'll need to sort out fonts before we can use image_exporter for everything (just shows up in the legend font in the mapbox_0 and mapbox_connectgaps images, it's a totally different font, look particularly at the c's and g's), but it's OK for this PR. It might mean that you're the only one who can run that noci_test script successfully, but if you're OK with that possibility then so am I 😉

💃 after the one last minor comment and tests pass.

etpinard · 2018-02-14T16:03:25Z

We'll need to sort out fonts before we can use image_exporter for everything (just shows up in the legend font in the mapbox_0 and mapbox_connectgaps images

Ok. Referencing #1972

etpinard added 10 commits February 12, 2018 13:29

bump mapbox-gl to 0.44.0 + update src and test

8d60a78

add 'wrong mapbox-gl version' error

550d7f6

clean up scattermapbox event data tests

ae9cba8

add 'some' mapbox-gl css rule

fcb8c25

... mostly to hide mapbox-gl's own no-css warning that get injected into the DOM.

resolves #2346 - add (un)selected.marker color/size support

278adec

... to scattermapbox traces, along with fixing existing bugs and cleaning up the convert logic (in 0.44.0, we no longer have to generate a hacky hash stops array 🎉

make scattermapbox first render faster

8443d63

- by setting up paint and layout props during the 1st addLayer call and by setting up the source during the 1st addSource call, as opposed to having an blank 'init' and a generic 'update' step.

fix scattermapbox hover & selection for 180 < lon < 360

de42330

lint a few things in mapbox subplot src files

eed0dd6

update mapbox image generation script

bc17361

update mapbox baselines (using new image-exporter)

9cdba10

etpinard added bug something broken feature something new type: maintenance labels Feb 12, 2018

etpinard mentioned this pull request Feb 12, 2018

Update mapbox-gl requirement #2029

Closed

etpinard added this to the v1.35.0 milestone Feb 12, 2018

etpinard added 3 commits February 13, 2018 12:02

fixes #2343 - clear select outlines on mapbox zoomstart

3d4befc

clear select outlines on 1st scroll event on cartesian subplots

51c3128

- see #2343 (comment) for more details on this issue.

fixup + 🔒 (un)selected fallbacks

1998f90

This was referenced Feb 13, 2018

Better big data support for scattermapbox #1885

Closed

JSPM: mapbox-gl error processing package #880

Closed

etpinard added status: reviewable and removed status: in progress labels Feb 13, 2018

alexcjohnson reviewed Feb 13, 2018

View reviewed changes

revert patch in (un)hover event data assertion

0ef2ba6

alexcjohnson reviewed Feb 14, 2018

View reviewed changes

🔪 dumb abstraction

b79abb5

etpinard merged commit 4aa511a into master Feb 14, 2018

etpinard deleted the bump-mapbox-gl branch February 14, 2018 16:03

nicolaskruchten mentioned this pull request Feb 21, 2018

Issue with npm install react-plotly.js plotly.js plotly/react-plotly.js#46

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump mapbox gl to 0.44.0 #2361

Bump mapbox gl to 0.44.0 #2361

etpinard commented Feb 12, 2018 •

edited

Loading

jackparmer commented Feb 12, 2018

alexcjohnson commented Feb 12, 2018

etpinard commented Feb 13, 2018

etpinard commented Feb 13, 2018

alexcjohnson Feb 13, 2018

etpinard Feb 13, 2018

alexcjohnson Feb 13, 2018

etpinard Feb 13, 2018

alexcjohnson Feb 13, 2018

alexcjohnson Feb 14, 2018

alexcjohnson commented Feb 14, 2018

etpinard commented Feb 14, 2018

Bump mapbox gl to 0.44.0 #2361

Bump mapbox gl to 0.44.0 #2361

Conversation

etpinard commented Feb 12, 2018 • edited Loading

jackparmer commented Feb 12, 2018

alexcjohnson commented Feb 12, 2018

etpinard commented Feb 13, 2018

etpinard commented Feb 13, 2018

alexcjohnson Feb 13, 2018

Choose a reason for hiding this comment

etpinard Feb 13, 2018

Choose a reason for hiding this comment

alexcjohnson Feb 13, 2018

Choose a reason for hiding this comment

etpinard Feb 13, 2018

Choose a reason for hiding this comment

alexcjohnson Feb 13, 2018

Choose a reason for hiding this comment

alexcjohnson Feb 14, 2018

Choose a reason for hiding this comment

alexcjohnson commented Feb 14, 2018

etpinard commented Feb 14, 2018

etpinard commented Feb 12, 2018 •

edited

Loading