extend zhoverformat to 2d histogram types #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
approved these changes
Oct 27, 2017
| @@ -546,6 +549,121 @@ describe('hover info', function() { | |||
| .catch(fail) | |||
| .then(done); | |||
| }); | |||
|
|
|||
| it('should display correct label content with specified format - contour', function(done) { | |||
| handleStyleDefaults(traceIn, traceOut, coerce, layout, lineDfltColor, 2); | ||
| handleStyleDefaults(traceIn, traceOut, coerce, layout, { | ||
| hasHover: false, | ||
| defaultColor: lineDfltColor, |
There was a problem hiding this comment.
🔈 Shoutout to @rreusser 's numerous carpet image mocks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2106 interacted with #2113 - still not quite sure why this didn't show up in the tests before but no matter: two more types need
zhoverformat:histogram2dandhistogram2dcontour.contourcarpetwould need it as well, but it doesn't support hover at all right now.Used the opportunity to 🌴 a little bit, moving
zhoverformatintocontour/style_defaultsand a newheatmap/style_defaultsAlso short-circuited
supplyDefaultsforhistogram2d(contour)with no data, as we do for other trace types.cc @etpinard