Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotly.react #2341

Merged
merged 40 commits into from
Feb 9, 2018
Merged

Plotly.react #2341

merged 40 commits into from
Feb 9, 2018

Commits on Feb 6, 2018

  1. Plotly.react

    @alexcjohnson
    alexcjohnson committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    54b6969 View commit details
    Browse the repository at this point in the history

  2. remove flagAxForDelete from _restyle

    @alexcjohnson
    alexcjohnson committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    aab4f11 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. allow 0 in pushUnique 

    so we can use it to make index arrays
    @alexcjohnson
    alexcjohnson committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    45c56b0 View commit details
    Browse the repository at this point in the history

  2. test Plotly.react with component arrays

    @alexcjohnson
    alexcjohnson committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    e58b74d View commit details
    Browse the repository at this point in the history

  3. _skipSD -> _skipDefaults

    @alexcjohnson
    alexcjohnson committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1074804 View commit details
    Browse the repository at this point in the history

  4. test of polar toggle staticPlot

    @alexcjohnson
    alexcjohnson committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    0548db3 View commit details
    Browse the repository at this point in the history

  5. multiline if statements for better debugging

    @alexcjohnson
    alexcjohnson committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    698fa4f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. only add _private attrs to legend after supplyDefaults 

    width and height looked to Plotly.react like attributes -> _width, _height
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    3c56243 View commit details
    Browse the repository at this point in the history

  2. cleanData should modify textposition in place 

    so as to not muck up plotly.react immutable logic
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    f01bab9 View commit details
    Browse the repository at this point in the history

  3. don't slice uneven arrays in scatter and related traces 

    instead just record the length as fullTrace._length
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    2fbd97c View commit details
    Browse the repository at this point in the history

  4. stop slicing and generating fake arrays in scatter3d and surface defa… 

    …ults
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    f873b26 View commit details
    Browse the repository at this point in the history

  5. remove old obsolete exponentformat/showexponent fallback

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    5aaa0df View commit details
    Browse the repository at this point in the history

  6. cleaner handling of bin defaults

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7a3b075 View commit details
    Browse the repository at this point in the history

  7. test_dashboard: highlight the displayed mock in search results

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    5814642 View commit details
    Browse the repository at this point in the history

  8. store slider & updatemenu dimensions in _private attrs

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    8fbe06e View commit details
    Browse the repository at this point in the history

  9. stop slicing data arrays in scattergeo

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    2 Configuration menu
    Copy the full SHA
    afc05c9 View commit details
    Browse the repository at this point in the history

  10. hacky handling for reshaped arrays in Plotly.react

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    2 Configuration menu
    Copy the full SHA
    898c39d View commit details
    Browse the repository at this point in the history

  11. handle transforms in Plotly.react - by looking at _fullInput

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    e9270fc View commit details
    Browse the repository at this point in the history

  12. clean up carpet pushing stuff back to _fullTrace late 

    except zmin/zmaxz, just ignore for now, we need to add these.
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    414a9b8 View commit details
    Browse the repository at this point in the history

  13. annotatinons3d pdata -> _pdata

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    e982ca1 View commit details
    Browse the repository at this point in the history

  14. fix for 3d scenes modifying axes range to linear

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    2 Configuration menu
    Copy the full SHA
    b856ad8 View commit details
    Browse the repository at this point in the history

  15. test a bunch of mocks for noop react redraws

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    88ad7f2 View commit details
    Browse the repository at this point in the history

  16. review comments - 🔪 commented-out code, comment on cleanData

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    ade3cca View commit details
    Browse the repository at this point in the history

  17. fixes for mapbox with Plotly.react

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    4b98be6 View commit details
    Browse the repository at this point in the history

  18. update polar for Plotly.react compatibility

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    3178b2e View commit details
    Browse the repository at this point in the history

  19. stop filling new [] in pie defaults

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    564dff6 View commit details
    Browse the repository at this point in the history

  20. fix bugs in rangeslider with explicit range and relayout 

    the range_slider_multiple mock showed the first bug, but I updated it so neither bound matches the default [-1, 6]
second bug was that impliedEdits were missing so some range updates wouldn't work
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    be4932d View commit details
    Browse the repository at this point in the history

  21. clean up rangeselector for Plotly.react

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    0752aa5 View commit details
    Browse the repository at this point in the history

  22. update scatterternary for Plotly.react

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    9ba4be9 View commit details
    Browse the repository at this point in the history

  23. avoid NaN in (un)selected.marker.opacity 

    NaN !== NaN wat was breaking Plotly.react.
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    1 Configuration menu
    Copy the full SHA
    9795b69 View commit details
    Browse the repository at this point in the history

  24. fix for transformed histograms to give consistent _fullInput 

    🤦 transforms...
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    57c7d6c View commit details
    Browse the repository at this point in the history

  25. more complete diffing of config 

    thank you airfoil.json for including a config arg
    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    3a11062 View commit details
    Browse the repository at this point in the history

  26. update scattergeo test

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    896471c View commit details
    Browse the repository at this point in the history

  27. wider acceptance range for toimage test

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    e12ce1b View commit details
    Browse the repository at this point in the history

  28. more complete set of Plotly.react noop mocks to test

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    46c6642 View commit details
    Browse the repository at this point in the history

  29. lint

    @alexcjohnson
    alexcjohnson committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    4197c32 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. fix scattergl uneven array handling

    @alexcjohnson
    alexcjohnson committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    f9d6151 View commit details
    Browse the repository at this point in the history

  2. updated gl3d_ribbons mock 

    no idea why this changed...
    @alexcjohnson
    alexcjohnson committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    c8a07e8 View commit details
    Browse the repository at this point in the history

  3. reset package-lock to master 

    and then npm i using node 8.9.4, npm 5.6.0, so it seems to last...
    @alexcjohnson
    alexcjohnson committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    2a7d640 View commit details
    Browse the repository at this point in the history

  4. get the right _xlength for surface if x is 2D 

    There are a bunch of extra edge cases here if the x/y/z arrays
don't have one of the expected sizes/dimensionalities... but this
covers more than it used to anyhow, and gets the ribbons mock right.
    @alexcjohnson
    alexcjohnson committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    5d6a4a0 View commit details
    Browse the repository at this point in the history