Faster trace visibility toggling #2837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DRY scalar-to-array repeat option logic - DRY get-viewport logic - build scene viewport and range option once per scene (not per trace)
- so that gl-based trace can call their plot methods w/ an empty array of traces and just work. - this makes restyle(gd, 'visible', false) work properly for scattergl traces
... to plot toggle scattergl 'visible' w/o having editType 'calc',
and hence w/o having to rebuild to scene options from scratch.
- to not have to guard against visible!==true traces in _module.style - to shortcut full list of modules in other places downstream
etpinard
commented
Jul 23, 2018
| } | ||
| } | ||
|
|
||
| Plotly.plot(gd, fig).then(function() { |
There was a problem hiding this comment.
This is broken on master, consider this a bug fix.
|
Love the concept! But it looks like autoranged axes aren't updated with the faster logic. I'll hold off reviewing until that's sorted out as I suspect it's going to be a bit involved - likely by maintaining separate
|
... and looks like we don't have any tests covering these cases 😑 |
This was referenced Jul 26, 2018
|
Abandoned. See #2860 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by changing
visiblefrom a 'calc' to a 'plot' edit type and using a "visible batch" in the scattergl code, similar to how selections are currently handled.Graphs will slow calc steps will benefit the most. For example, on a 1e6 scattergl graph,
clocks in at about 30ms which is about 50x faster than on master 🐎
Eventually, we could augment this PR by adding a new edit type that would bypass
drawFrameworkandinitInteractions(which are very 🐢 for sploms), but I'll leave that for later if ok.Note that commits 3790734 and b816a8e might be a bit controversial and may have some side-effects during subplot/trace removal the spli through our tests, so I wouldn't mind a second opinion there.
I would appreciate if @dy could take a look at e85725a and cf65abd
To be merged in #2823
cc @alexcjohnson and @dy