Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dark highlights from Mesh3d #3463

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Disable dark highlights from Mesh3d #3463

merged 2 commits into from
Jan 23, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 23, 2019

Fixes #3462 using newly published gl-mesh3d module by not allowing negative highlights.
Example below illustrate a desirable result after using gl-mesh3d v.2.0.6
@etpinard cc: @plotly/plotly_js
newplot 1 1

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jan 23, 2019
@etpinard
Copy link
Contributor

Nice fix. Is there any way to test this fix?

@archmoj
Copy link
Contributor Author

archmoj commented Jan 23, 2019

I used a mobile with this codepen.
Unfortunately I don't see a way to write a test for it.

@etpinard
Copy link
Contributor

Ok, sounds good 💃

@archmoj archmoj merged commit a956a22 into master Jan 23, 2019
@archmoj archmoj deleted the surface-lighting branch January 23, 2019 13:35
@etpinard
Copy link
Contributor

Thanks for the quick fix @archmoj !

This thing will be out today, but I'll wait a couple more hours before releasing 1.44.1 in case other regression are detected.

@archmoj
Copy link
Contributor Author

archmoj commented Jan 23, 2019

It would be great if we could follow up with #3380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants