Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'hovertext' attribute to all traces that support hover 'text' #3553

Merged
merged 3 commits into from
Feb 19, 2019

Conversation

etpinard
Copy link
Contributor

resolves #3450 (the backward-compatible part of that issue that is)

This PR add hovertext to all traces that currently make use of the text attribute to add content to the hover labels. This make hovertext standard across all traces that support hover, including for traces that support on-graph text.

Note that if text and hovertext are present in the same trace, hovertext wins out.

cc @plotly/plotly_js and @nicolaskruchten

@etpinard etpinard added this to the v1.45.0 milestone Feb 18, 2019
@etpinard
Copy link
Contributor Author

@antoinerg would you mind reviewing this thing? Thanks!

@antoinerg
Copy link
Contributor

This PR add hovertext to all traces that currently make use of the text attribute to add content to the hover labels. This make hovertext standard across all traces that support hover, including for traces that support on-graph text.

Thanks @etpinard for improving our coverage!

💃

@etpinard etpinard merged commit 7da95e1 into master Feb 19, 2019
@etpinard etpinard deleted the more-hovertext branch February 19, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated text / use hovertext for traces that don't support on-graph text
2 participants