Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showEditInChartStudio config option #4061

Merged
merged 6 commits into from
Jul 19, 2019
Merged

Conversation

etpinard
Copy link
Contributor

as a supplement to showSendToCloud (ref: #3307)

Demo: https://codepen.io/etpinard/pen/YmzbYG

Peek 2019-07-18 15-27

Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten

@etpinard etpinard added this to the v1.49.0 milestone Jul 18, 2019
@@ -26,6 +26,7 @@
<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062

@etpinard
Copy link
Contributor Author

Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.

Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.

Any objections @plotly/plotly_js ?

@antoinerg
Copy link
Contributor

Any objections @plotly/plotly_js ?

None from me, feel free to 🔪 !

  where we now expect devs to update icon definitions "by hand",
  w/o the use of `npm run preprocess`
  all required svg-icon things are in the
  `src/fonts/ploticon.js` file
@antoinerg
Copy link
Contributor

Thanks, @etpinard for the nice addition! I like the icon: it's very clear.

💃

@etpinard etpinard merged commit 56dd829 into master Jul 19, 2019
@etpinard etpinard deleted the showEditInChartStudio branch July 19, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants