Remove pull_font_svg step #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where we now expect devs to update icon definitions "by hand", w/o the use of `npm run preprocess`
all required svg-icon things are in the `src/fonts/ploticon.js` file
|
When working in that part of the codebase, I remember being puzzled about it. Getting rid of those 1719 lines will make things simpler for newcomers. Thanks a lot for the cleanup 💃 💃 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4061 (comment) - to be merged in #4061
cc @plotly/plotly_js - I'm very happy with this 😄