adding support for defining groups in data.transforms.groups using ty… #4410
Conversation
|
@etpinard not sure how to assign you as an official reviewer (first time doing this kinda thing) |
|
Thanks very much for the PR @danieljblinick ! Would you be interested in adding a test to lock down the behavior? Adding one |
|
@etpinard added a test, lemme know if thats what you had in mind. |
| @@ -318,6 +332,22 @@ describe('groupby', function() { | |||
| .catch(failTest) | |||
| .then(done); | |||
| }); | |||
|
|
|||
| it ('Plotly.plot should group points properly using typed array', function(done) { | |||
There was a problem hiding this comment.
This line should be
it('Plotly.plot should group points properly using typed array', function(done) {to make npm run lint pass.
| }) | ||
| .catch(failTest) | ||
| .then(done); | ||
| }) |
There was a problem hiding this comment.
This line should be
});to make npm run lint pass.
|
@danieljblinick your test looks good. Nice job! You'll need to push another commit to make the lint test ( |
|
@etpinard seems like all is passing! lemme know if there is anything else :) |
|
Thank you very much @danieljblinick !! This will be part of our upcoming |
|
@etpinard is there any way you can send me a tagged release with this feature? i would really appreciate it if its possible, cause we kind of need the feature. thanks! |
|
@danieljblinick I believe we're planning the next release in early January. Can you just use the built files from this PR? You can grab whichever flavor you need from here: |
the idea here is just to allow groups to be defined in data.transforms using typed arrays as well as regular arrays, to save on space