Skip to content

Commit

Permalink
fix(bullet): make dimensions required props
Browse files Browse the repository at this point in the history
  • Loading branch information
wyze committed Nov 9, 2020
1 parent fe0e43c commit 597b6a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/bullet/src/Bullet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const Bullet = (props: BulletSvgProps) => {
onMarkerClick,

role,
} = { height: 0, width: 0, ...defaultProps, ...props }
} = { ...defaultProps, ...props }

const { margin, innerWidth, innerHeight } = useDimensions(width, height, partialMargin)

Expand Down
1 change: 1 addition & 0 deletions packages/bullet/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export type BulletHandlers = {
}

export type BulletSvgProps = Partial<CommonBulletProps> &
Dimensions &
BulletHandlers &
ModernMotionProps & {
data: Datum[]
Expand Down

0 comments on commit 597b6a9

Please sign in to comment.