Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bullet): migrate package to typescript #1252

Merged
merged 18 commits into from
Nov 9, 2020
Merged

feat(bullet): migrate package to typescript #1252

merged 18 commits into from
Nov 9, 2020

Conversation

wyze
Copy link
Contributor

@wyze wyze commented Nov 6, 2020

Close #1224

@wyze wyze marked this pull request as draft November 6, 2020 04:30
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 6, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 597b6a9:

Sandbox Source
nivo Configuration
nivo-website Configuration

@wyze wyze mentioned this pull request Nov 6, 2020
Closed
12 tasks
@wyze wyze marked this pull request as ready for review November 6, 2020 23:25
@wyze wyze requested a review from plouc November 6, 2020 23:25
@wyze wyze mentioned this pull request Nov 6, 2020
Closed
11 tasks
@wyze wyze changed the title feat(bullet): init package migration to typescript feat(bullet): migrate package to typescript Nov 7, 2020
plouc
plouc requested changes Nov 7, 2020
View reviewed changes
packages/bullet/src/Bullet.tsx Outdated Show resolved Hide resolved
packages/bullet/src/Bullet.tsx Outdated Show resolved Hide resolved
packages/bullet/src/Bullet.tsx Outdated Show resolved Hide resolved
packages/bullet/src/Bullet.tsx Outdated Show resolved Hide resolved
packages/bullet/src/BulletItem.tsx Outdated Show resolved Hide resolved
packages/bullet/src/BulletRects.tsx Outdated Show resolved Hide resolved
packages/bullet/src/BulletRects.tsx Outdated Show resolved Hide resolved
packages/bullet/src/types.ts Outdated Show resolved Hide resolved
packages/bullet/src/types.ts Outdated Show resolved Hide resolved
packages/bullet/tests/Bullet.test.tsx Show resolved Hide resolved
wyze added 15 commits November 8, 2020 18:35
@wyze wyze force-pushed the bullet-typescript branch from 8cde390 to 2aff51d Compare November 9, 2020 00:36
@wyze wyze force-pushed the bullet-typescript branch from 9238036 to d63ad74 Compare November 9, 2020 03:53
@wyze wyze requested a review from plouc November 9, 2020 04:02
@wyze
Copy link
Contributor Author

wyze commented Nov 9, 2020

I think I addressed nearly everything, thanks for the review!

plouc
plouc requested changes Nov 9, 2020
View reviewed changes
packages/pie/src/Pie.tsx Outdated Show resolved Hide resolved
packages/pie/src/PieCanvas.tsx Outdated Show resolved Hide resolved
@wyze wyze force-pushed the bullet-typescript branch from 869115c to 597b6a9 Compare November 9, 2020 23:05
@wyze
Copy link
Contributor Author

wyze commented Nov 9, 2020

Good catch on the dimensions! Pushed the changes.

plouc
plouc approved these changes Nov 9, 2020
View reviewed changes
Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc plouc merged commit 8451c27 into master Nov 9, 2020
@plouc plouc deleted the bullet-typescript branch November 9, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plouc plouc plouc approved these changes

Assignees

@wyze wyze

Labels
🔫 bullet @nivo/bullet package nivo core team typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate @nivo/bullet to TypeScript
2 participants
@wyze @plouc