-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sunburst): use arcs package #1350
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd603c8:
|
87bc1d0
to
25c4338
Compare
}) | ||
}) | ||
|
||
describe('patterns & gradients', () => { | ||
it('should support patterns', () => { | ||
xit('should support patterns', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these tests no longer passed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the changes to bindDefs
cause this to fail. What is the reason behind those changes?
When will this PR be merged? Can't wait to add arc labels to sunburst! |
Co-authored-by: Neil Kistner <neil.kistner@gmail.com>
This PR makes use of the new
@nivo/arcs
package:useSpring
for every elementtransitionMode
which can be used to control the way nodes enter/exit@nivo/pie
arcLabelsRadiusOffset
I've also revised the types to use generic types from both
@nivo/core
and@nivo/arcs
, also changed theComputedDatum
to be more aligned with other packages.I've added a
path
property to the nodes, this way we can easily get a list of all the ancestors of a node, I thought it could be useful.There was a bug with the data generator for this chart, if you look at the current website, you'll see that the generated data get nested under the root
name
property each time you clickroll the dice
.I realized that the pie package no more require
lodash
(at least not as a direct dependency), and same forreact-spring
, so I removed them.There's also another change completely unrelated on the references page.