Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle Packing TypeScript migration #1360

Closed
wants to merge 25 commits into from

Conversation

plouc
Copy link
Owner

@plouc plouc commented Dec 22, 2020

⚠️ Depends on #1350 ⚠️

  • Add TS to @nivo/circle-packing, remove recompose and react-motion
  • Rename Bubble* to CirclePacking* for consistency
  • Add support for a custom circle component
  • Add custom filtering support for labels
  • Add support for a custom label component
  • Add zoom support to all implementations
  • Add support for onMouseEnter, onMouseMove and onMouseLeave
  • Add mouse handlers support to the canvas implementation
  • Disable circle-packing API pages/doc in the website (until it get fixed)
  • Change skipLibCheck to true in tsconfig
  • Fix some typings in @nivo/core declarations
  • Add types related to interactivity to @nivo/core declarations
  • Make sure we have a single version of @types/react by forcing its resolution
  • Expose hooks to be able to build completely custom charts
  • Fix HTML implementation overflow when zoomed in

@plouc plouc self-assigned this Dec 22, 2020
@plouc plouc added 🔴 circle-packing @nivo/circle-packing package typescript labels Dec 22, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce41279:

Sandbox Source
nivo Configuration
nivo-website Configuration

@plouc plouc marked this pull request as ready for review December 23, 2020 07:59
@stale
Copy link

stale bot commented Mar 23, 2021

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Mar 23, 2021
@stale
Copy link

stale bot commented Mar 30, 2021

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔴 circle-packing @nivo/circle-packing package stale typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant