Add inline security comments to extra-args validation in setup-python-env action#45
Merged
pmalarme merged 2 commits intofeature/add-documentation-and-copilot-instructionsfrom Feb 19, 2026
Conversation
8 tasks
…tion Co-authored-by: pmalarme <686568+pmalarme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation and copilot instructions based on feedback
Add inline security comments to extra-args validation in setup-python-env action
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
extra-argsvalidation loop in the composite action lacked comments explaining its security intent, and theshellcheck disabledirective didn't reference the validation—making the connection between the two implicit and fragile.Changes
.github/actions/setup-python-env/action.ymlNOTEdocumenting that--(end-of-options marker) is intentionally permitted by the regex; any following positional args would fail validationshellcheck disable=SC2086comment to include "all tokens validated above", explicitly tying the validation loop to theuv synccallTesting
uv run poe checkChecklist
Additional context
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.