Skip to content

Add inline security comments to extra-args validation in setup-python-env action #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmalarme merged 2 commits into from
Feb 19, 2026
Merged

Add inline security comments to extra-args validation in setup-python-env action #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa7b55
Initial plan
Copilot Feb 19, 2026
5379c4d
Add security comments to extra-args validation in setup-python-env ac…
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/setup-python-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ runs:
args="$args --group docs"
fi
if [[ -n "$EXTRA_ARGS" ]]; then
# Validate each whitespace-split token: must start with '-' and contain only safe flag characters.
# NOTE: '--' (end-of-options marker) is intentionally allowed; positional args would fail validation.
for arg in $EXTRA_ARGS; do
if [[ ! "$arg" =~ ^-[a-zA-Z0-9=._:/@+-]+$ ]]; then
echo "::error::Unsafe extra-args token: '$arg'. Each token must start with '-' and contain only safe flag characters." >&2
exit 1
fi
done
fi
# shellcheck disable=SC2086 # intentional word-splitting for uv flags
# shellcheck disable=SC2086 # intentional word-splitting for uv flags (all tokens validated above)
uv sync $args $EXTRA_ARGS