Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for three.js r135 #327

Closed
discosultan opened this issue Dec 5, 2021 · 2 comments
Closed

Support for three.js r135 #327

discosultan opened this issue Dec 5, 2021 · 2 comments
Labels
feature request New feature request

Comments

@discosultan
Copy link

https://github.com/vanruesc/postprocessing/blob/a3c97453ba9e7fcd3f5435248409acb73b09e6a2/package.json#L76
@discosultan discosultan added the feature request New feature request label Dec 5, 2021
@vanruesc
Copy link
Member

vanruesc commented Dec 6, 2021 •
edited
Loading

Thanks for the report!

The peer dependency specifies versions of three that are currently guaranteed to work with postprocessing. It's mostly a recommendation and postprocessing usually works with the latest revision of three. However, there have been breaking changes in three r133 and now in r135 related to SRGB8_ALPHA8 that require back-compat adjustments in postprocessing.

It's on my radar and I'm going to push a new release tomorrow that addresses this.

@marcofugaro
Copy link
Member

Just an heads up, SRGB8_ALPHA8 will be enabled again in r136

vanruesc added a commit that referenced this issue Dec 6, 2021
@vanruesc
Update getTextureDecoding.js
97510a4 
#327 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@discosultan @marcofugaro @vanruesc