Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links jump to section (part 2) + fix tarot images #1867

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

orta
Copy link
Contributor

@orta orta commented Mar 30, 2022

What

I went through all the links in #1835 and verified them against the site and also fixed the URLs to the tarot cards in the demos

Checklist

  • Documentation updated
  • Ready to be merged

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/7GBvJr6TaExgPixZsDsGeMHNtn2P
✅ Preview: https://react-spring-io-git-fork-orta-links-jump-to-section-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 550b4e0:

Sandbox Source
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
spring-cards-stack Configuration
spring-exit-before-enter Configuration
spring-masonry Configuration
spring-notification-hub Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration

@orta
Copy link
Contributor Author

orta commented Mar 30, 2022

I did a quick look into using rehype-slug which mdx uses to try and do this automatically, but it'd require pulling out the mdx file, parsing it and grabbing the header - which is a bit of an overkill

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7783d77:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
spring-draggable-list Configuration
pmndrs/react-spring Configuration
spring-image-fade Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration

@joshuaellis
Copy link
Member

I did a quick look into using rehype-slug which mdx uses to try and do this automatically, but it'd require pulling out the mdx file, parsing it and grabbing the header - which is a bit of an overkill

I agree, plus i'm working on redoing the documentation site, so this won't necessarily be an issue in the future.

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit d2d46cd into pmndrs:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants