fix(shallow): Extract shallow vanilla and react #2097

dbritto-dev · 2023-10-03T18:08:27Z

Related Issues or Discussions

Fix #2095

Summary

Split shallow in two modules: zustand/shallow and zustand/shallow/react
Split tests for vanilla and react

Check List

yarn run prettier for formatting code and docs

vercel · 2023-10-03T18:08:30Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zustand-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 4, 2023 11:46pm

codesandbox-ci · 2023-10-03T18:08:54Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 223c67f:

Sandbox	Source
React	Configuration
React TypeScript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
Next.js	Configuration
@pavlobu/zustand demo	Configuration

dbritto-dev · 2023-10-03T18:15:49Z

@dai-shi here you go

dai-shi

tests/vanilla/shadow.test.tsx -> tests/vanilla/shallow.test.tsx ?
(Not sure if I prefer the folder structure under tests, but I know what you want.)

We also need to change package.json. Please create ./shallow/react entry point. (see how ./middleware/immer is defined.

dbritto-dev · 2023-10-04T04:04:13Z

tests/vanilla/shadow.test.tsx -> tests/vanilla/shallow.test.tsx ? (Not sure if I prefer the folder structure under tests, but I know what you want.)

We also need to change package.json. Please create ./shallow/react entry point. (see how ./middleware/immer is defined.

@dai-shi about folder structure under tests I'm following the structure on jotai tests

dbritto-dev · 2023-10-04T04:46:40Z

@dai-shi all yours, keep me in the loop

dai-shi · 2023-10-04T05:01:40Z

about folder structure under tests I'm following the structure on jotai tests

wait, I think I misunderstood the jotai structure for "src" too.
if we were to follow it, it will be:

zustand/shallow
zustand/vanilla/shallow
zustand/react/shallow

What do you think?

dbritto-dev · 2023-10-04T05:13:32Z

@dai-shi sounds good to me let me update it to match the src structure too

dbritto-dev · 2023-10-04T06:00:10Z

@dai-shi all yours

dai-shi

Thanks for the revision. Looks good overall. See the comments.

src/vanilla/shallow.ts

src/shallow.ts

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

dbritto-dev · 2023-10-04T16:14:36Z

@dai-shi all yours, keep me in the loop

dai-shi

The code looks good.
Can you try creating a codesandbox example? It should fail.
We need to add two build scripts like this:

"build:vanilla:shallow": "rollup -c --config-vanilla_shallow",
"build:react:shallow": "rollup -c --config-react_shallow",

and the codesandbox example should work.

dbritto-dev · 2023-10-04T23:50:38Z

@dai-shi locally works, let's ship it haha :D I'm just joking

dai-shi · 2023-10-05T11:06:00Z

This doesn't work:
https://codesandbox.io/s/react-typescript-forked-y24k6g fb8b211

But, this does work:
https://codesandbox.io/s/react-typescript-forked-khknwm 223c67f

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zustand](https://togithub.com/pmndrs/zustand) | [`4.4.1` -> `4.4.6`](https://renovatebot.com/diffs/npm/zustand/4.4.1/4.4.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/zustand/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zustand/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zustand/4.4.1/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zustand/4.4.1/4.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/zustand (zustand)</summary> ### [`v4.4.6`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.6) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.5...v4.4.6) v4.4.5 has an issue with some TypeScript configs about module resolution. It should be fixed now. Thanks for the patience. #### What's Changed - Update export types by [@dbritto-dev](https://togithub.com/dbritto-dev) in [pmndrs/zustand#2170 #### New Contributors - [@cheatkey](https://togithub.com/cheatkey) made their first contribution in [pmndrs/zustand#2147 - [@frixaco](https://togithub.com/frixaco) made their first contribution in [pmndrs/zustand#2166 **Full Changelog**: pmndrs/zustand@v4.4.5...v4.4.6 ### [`v4.4.5`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.5) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.4...v4.4.5) Hopefully, it should fix some issues with Node.js environment including Next.js. #### What's Changed - fix: importing CJS React in ESM by [@dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#2154 - Apply publint recommendations by [@dbritto-dev](https://togithub.com/dbritto-dev) in [pmndrs/zustand#2157 #### New Contributors - [@plrs9816](https://togithub.com/plrs9816) made their first contribution in [pmndrs/zustand#2137 - [@Brammm](https://togithub.com/Brammm) made their first contribution in [pmndrs/zustand#2139 - [@sobies93](https://togithub.com/sobies93) made their first contribution in [pmndrs/zustand#2142 **Full Changelog**: pmndrs/zustand@v4.4.4...v4.4.5 ### [`v4.4.4`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.4) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.3...v4.4.4) There was a tiny issue in v4.4.3, which broke with some bundlers, which this version fixes. #### What's Changed - fix(build): patch entry points zustand/shallow for CJS by [@dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#2128 **Full Changelog**: pmndrs/zustand@v4.4.3...v4.4.4 ### [`v4.4.3`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.3) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.2...v4.4.3) The changes in v4.4.2 were troublesome for some users. This version should fix/mitigate such cases. #### What's Changed - fix(shallow): Extract shallow vanilla and react by [@dbritto-dev](https://togithub.com/dbritto-dev) in [pmndrs/zustand#2097 - fix(types): mitigate devtools typing by [@dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#2099 **Full Changelog**: pmndrs/zustand@v4.4.2...v4.4.3 ### [`v4.4.2`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.2) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.1...v4.4.2) This adds `useShallow` hook to cover some use cases that are deprecated with v4.4.0 change. Check out [the guide](https://togithub.com/pmndrs/zustand/blob/ec538e9d4c0b9b5759e6dfd0fd3c9a21f8236949/docs/guides/prevent-rerenders-with-use-shallow.md). ##### Migration Guide [#1991](https://togithub.com/pmndrs/zustand/issues/1991) requires something like below if you are using the `devtools` middleware *and* TypeScript. ```diff import { devtools } from 'zustand/middleware' + import type {} from '@redux-devtools/extension' ``` ##### What's Changed - fix(types)(middleware/devtools): avoid copying types by [@dai-shi](https://togithub.com/dai-shi) in [pmndrs/zustand#1991 - fix(traditional): make defaultEqualityFn optional in TS Types by [@charkour](https://togithub.com/charkour) in [pmndrs/zustand#2060 - feat: add useShallow by [@FaberVitale](https://togithub.com/FaberVitale) in [pmndrs/zustand#2090 ##### New Contributors - [@aykutkardas](https://togithub.com/aykutkardas) made their first contribution in [pmndrs/zustand#1993 - [@michelts](https://togithub.com/michelts) made their first contribution in [pmndrs/zustand#1997 - [@elusive](https://togithub.com/elusive) made their first contribution in [pmndrs/zustand#2001 - [@mayank1513](https://togithub.com/mayank1513) made their first contribution in [pmndrs/zustand#2015 - [@fdb](https://togithub.com/fdb) made their first contribution in [pmndrs/zustand#2029 - [@tmkx](https://togithub.com/tmkx) made their first contribution in [pmndrs/zustand#2032 - [@OshriAsulin](https://togithub.com/OshriAsulin) made their first contribution in [pmndrs/zustand#2028 - [@ivanquirino](https://togithub.com/ivanquirino) made their first contribution in [pmndrs/zustand#2047 - [@stavkamil](https://togithub.com/stavkamil) made their first contribution in [pmndrs/zustand#2071 - [@NaamuKim](https://togithub.com/NaamuKim) made their first contribution in [pmndrs/zustand#2088 - [@FaberVitale](https://togithub.com/FaberVitale) made their first contribution in [pmndrs/zustand#2090 **Full Changelog**: pmndrs/zustand@v4.4.1...v4.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

dbritto-dev added 4 commits October 3, 2023 13:04

Update readmes

ff520aa

Splitting shallow in two modules

9aff2cb

Update tests

3c3d8f7

Minor changes

26dfb98

dbritto-dev requested a review from dai-shi October 3, 2023 18:08

dbritto-dev self-assigned this Oct 3, 2023

dbritto-dev added the enhancement New feature or request label Oct 3, 2023

vercel bot deployed to Preview October 3, 2023 18:10 View deployment

Minor changes

7886dba

vercel bot deployed to Preview October 3, 2023 18:13 View deployment

dbritto-dev changed the title ~~Extract shallow vanilla~~ Extract shallow vanilla and react Oct 3, 2023

dai-shi requested changes Oct 3, 2023

View reviewed changes

dbritto-dev added 2 commits October 3, 2023 23:04

Rename shadow.tests.tsx to shallow.test.tsx

8058d56

Add new entrypoint for shallow/react

4f2e488

dbritto-dev requested a review from dai-shi October 4, 2023 04:05

vercel bot deployed to Preview October 4, 2023 04:06 View deployment

dbritto-dev added 4 commits October 4, 2023 00:29

Update structure

9b88d9f

Update shallow to export from vanilla and react

54d8392

Add vanilla/shallow and react/shallow entrypoints

710b7a1

Update tests

f39dd32

vercel bot deployed to Preview October 4, 2023 05:33 View deployment

Update readmes

64184df

vercel bot deployed to Preview October 4, 2023 05:35 View deployment

dai-shi reviewed Oct 4, 2023

View reviewed changes

src/vanilla/shallow.ts Outdated Show resolved Hide resolved

src/shallow.ts Outdated Show resolved Hide resolved

Update src/shallow.ts

b8afbf2

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

vercel bot deployed to Preview October 4, 2023 15:45 View deployment

Minor changes

8921513

vercel bot deployed to Preview October 4, 2023 15:51 View deployment

dbritto-dev added 3 commits October 4, 2023 11:01

Update readmes

4a64b9d

Update readmes

08864a7

Update tests

fb8b211

vercel bot deployed to Preview October 4, 2023 16:02 View deployment

dbritto-dev requested a review from dai-shi October 4, 2023 16:14

dai-shi reviewed Oct 4, 2023

View reviewed changes

Merge branch 'main' into extract-shallow-vanilla

0eb39ff

vercel bot deployed to Preview October 4, 2023 23:39 View deployment

Minor changes

223c67f

vercel bot deployed to Preview October 4, 2023 23:46 View deployment

dbritto-dev requested a review from dai-shi October 4, 2023 23:48

dai-shi approved these changes Oct 5, 2023

View reviewed changes

dai-shi added this to the v4.4.3 milestone Oct 5, 2023

dai-shi changed the title ~~Extract shallow vanilla and react~~ fix(shallow): Extract shallow vanilla and react Oct 5, 2023

dai-shi merged commit e414f7c into pmndrs:main Oct 5, 2023
35 checks passed

dbritto-dev deleted the extract-shallow-vanilla branch October 5, 2023 15:08

renovate bot mentioned this pull request Oct 22, 2023

chore(deps): update all (major) dplantera/react-pdf-filling-assistant#25

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(shallow): Extract shallow vanilla and react #2097

fix(shallow): Extract shallow vanilla and react #2097

dbritto-dev commented Oct 3, 2023 •

edited

Loading

vercel bot commented Oct 3, 2023 •

edited

Loading

codesandbox-ci bot commented Oct 3, 2023 •

edited

Loading

dbritto-dev commented Oct 3, 2023

dai-shi left a comment

dbritto-dev commented Oct 4, 2023 •

edited

Loading

dbritto-dev commented Oct 4, 2023

dai-shi commented Oct 4, 2023

dbritto-dev commented Oct 4, 2023

dbritto-dev commented Oct 4, 2023

dai-shi left a comment

dbritto-dev commented Oct 4, 2023

dai-shi left a comment

dbritto-dev commented Oct 4, 2023

dai-shi commented Oct 5, 2023

fix(shallow): Extract shallow vanilla and react #2097

fix(shallow): Extract shallow vanilla and react #2097

Conversation

dbritto-dev commented Oct 3, 2023 • edited Loading

Related Issues or Discussions

Summary

Check List

vercel bot commented Oct 3, 2023 • edited Loading

codesandbox-ci bot commented Oct 3, 2023 • edited Loading

dbritto-dev commented Oct 3, 2023

dai-shi left a comment

Choose a reason for hiding this comment

dbritto-dev commented Oct 4, 2023 • edited Loading

dbritto-dev commented Oct 4, 2023

dai-shi commented Oct 4, 2023

dbritto-dev commented Oct 4, 2023

dbritto-dev commented Oct 4, 2023

dai-shi left a comment

Choose a reason for hiding this comment

dbritto-dev commented Oct 4, 2023

dai-shi left a comment

Choose a reason for hiding this comment

dbritto-dev commented Oct 4, 2023

dai-shi commented Oct 5, 2023

dbritto-dev commented Oct 3, 2023 •

edited

Loading

vercel bot commented Oct 3, 2023 •

edited

Loading

codesandbox-ci bot commented Oct 3, 2023 •

edited

Loading

dbritto-dev commented Oct 4, 2023 •

edited

Loading