Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): separate immer middleware #915

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 18, 2022

otherwise, non-immer users have to install immer to use any middleware.

this is a follow-up pr to #725.

@dai-shi dai-shi added this to the v4.0.0 milestone Apr 18, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c1c855c:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@github-actions
Copy link

Size Change: +1.2 kB (+4%)

Total Size: 28.9 kB

Filename Size Change
dist/esm/middleware.js 2.94 kB -101 B (-3%)
dist/middleware.js 3.04 kB -158 B (-5%)
dist/system/middleware.development.js 3.03 kB -131 B (-4%)
dist/system/middleware.production.js 1.95 kB -81 B (-4%)
dist/umd/middleware.development.js 3.15 kB -168 B (-5%)
dist/umd/middleware.production.js 1.95 kB -110 B (-5%)
dist/esm/middleware/immer.js 210 B +210 B (new file) 🆕
dist/middleware/immer.js 373 B +373 B (new file) 🆕
dist/system/middleware/immer.development.js 292 B +292 B (new file) 🆕
dist/system/middleware/immer.production.js 187 B +187 B (new file) 🆕
dist/umd/middleware/immer.development.js 514 B +514 B (new file) 🆕
dist/umd/middleware/immer.production.js 371 B +371 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/context.js 518 B
dist/esm/context.js 448 B
dist/esm/index.js 400 B
dist/esm/shallow.js 272 B
dist/esm/vanilla.js 377 B
dist/index.js 642 B
dist/shallow.js 318 B
dist/system/context.development.js 572 B
dist/system/context.production.js 393 B
dist/system/index.development.js 575 B
dist/system/index.production.js 385 B
dist/system/shallow.development.js 338 B
dist/system/shallow.production.js 253 B
dist/system/vanilla.development.js 444 B
dist/system/vanilla.production.js 270 B
dist/umd/context.development.js 662 B
dist/umd/context.production.js 488 B
dist/umd/index.development.js 787 B
dist/umd/index.production.js 564 B
dist/umd/shallow.development.js 447 B
dist/umd/shallow.production.js 344 B
dist/umd/vanilla.development.js 590 B
dist/umd/vanilla.production.js 378 B
dist/vanilla.js 456 B

compressed-size-action

@dai-shi dai-shi merged commit 2a2c180 into main Apr 18, 2022
@dai-shi dai-shi deleted the fix/immer-in-separate-bundle branch April 18, 2022 01:06
@dai-shi dai-shi mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant