-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict replace
types
#944
Strict replace
types
#944
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b147391:
|
Thanks for submitting this. After noticing #915, I think one of the issue is Does anyone else follow this? have questions? |
Inlining is not a good idea because we'd have to update it everytime immer updates. I think we'd have to declare immer as a peer dependency. There are other solutions but they are very hacky. Merge or reject, I'm open to whatever you think is the right thing to do here. |
Closing this, but this is good to know we have such an option. Thanks. |
No problems |
Opening a PR as requested here: #725 (comment)