Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict replace types #944

Closed
wants to merge 4 commits into from
Closed

Strict replace types #944

wants to merge 4 commits into from

Conversation

devanshj
Copy link
Contributor

@devanshj devanshj commented May 1, 2022

Opening a PR as requested here: #725 (comment)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b147391:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@devanshj devanshj changed the title Strict replace Strict replace types May 1, 2022
@dai-shi
Copy link
Member

dai-shi commented May 3, 2022

Thanks for submitting this.
This is important to have even if we don't merge it soon, as I can't do this.

After noticing #915, I think one of the issue is Draft type. We might need to inline it. I still think this is too complicated to realize strict replace.

Does anyone else follow this? have questions?

@devanshj
Copy link
Contributor Author

devanshj commented May 3, 2022

After noticing #915, I think one of the issue is Draft type. We might need to inline it.

Inlining is not a good idea because we'd have to update it everytime immer updates. I think we'd have to declare immer as a peer dependency. There are other solutions but they are very hacky.

Merge or reject, I'm open to whatever you think is the right thing to do here.

@dai-shi
Copy link
Member

dai-shi commented Jul 25, 2022

Closing this, but this is good to know we have such an option. Thanks.

@dai-shi dai-shi closed this Jul 25, 2022
@devanshj
Copy link
Contributor Author

No problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants