fix url encoding issue when writing href values to client_LocationBasedDefaults.html as part of SetDefaultColumnValuesImplementation() #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edDefaults.html as part of SetDefaultColumnValuesImplementation()
|
Nice work @jvossers , will merge today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharePoint is expecting a specific type of URL Encoding for href values in client_LocationBasedDefaults.html (the file which SharePoint produces to store the "Column default settings" for a document library) as can be observed when inspecting the file in the /Forms directory for the library after configuring defaults through the SharePoint UI. The type of encoding used by SharePoint leaves slashes alone and replaces spaces with %20 rather than '+' signs.
This PR addresses a bug in pnp framework (inside the SetDefaultColumnValuesImplementation method) where System.Web.HttpUtility.UrlEncode(path) is used to encode href values, which does not result in the type of encoding expected by SharePoint.