fix url encoding issue when writing href values to client_LocationBasedDefaults.html as part of SetDefaultColumnValuesImplementation()

src/lib/PnP.Framework.Test/Utilities/UrlUtilityTests.cs

@@ -36,5 +36,16 @@ public void ReplaceInvalidUrlCharsReturnsStrippedString()
             var invalidString = "a#%*\\:<>?/+|b";
             Assert.AreEqual("a---------------------------------b", invalidString.ReplaceInvalidUrlChars("---"));
         }
+
+        [TestMethod]
+        public void UrlPathEncodePerformsUrlEncodingButLeavesSlashesAlone()
+        {
+            var input = "/sites/site001/document library/folder abc";
+            var expected = "/sites/site001/document%20library/folder%20abc";
+
+            var actual = input.UrlPathEncode();
+
+            Assert.AreEqual(expected, actual);
+        }
     }
 }

src/lib/PnP.Framework/Extensions/ListExtensions.cs

@@ -1645,7 +1645,7 @@ private static void SetDefaultColumnValuesImplementation(this List list, IEnumer
                         path = path.Equals("/") ? list.RootFolder.ServerRelativeUrl : UrlUtility.Combine(list.RootFolder.ServerRelativeUrl, path);
                         // Find all in the same path:
                         var defaultColumnValuesInSamePath = columnValues.Where(x => x.FolderRelativePath == defaultColumnValue.FolderRelativePath);
-                        path = System.Web.HttpUtility.UrlEncode(path);
+                        path = path.UrlPathEncode();
 
                         var xATag = new XElement("a", new XAttribute("href", path));
 

src/lib/PnP.Framework/Utilities/UrlUtility.cs

@@ -143,16 +143,26 @@ public static string StripInvalidUrlChars(this string content)
             return ReplaceInvalidUrlChars(content, "");
         }
         /// <summary>
-        /// Replaces invalid charcters with other characters
+        /// Replaces invalid characters with other characters
         /// </summary>
         /// <param name="content">Url value</param>
         /// <param name="replacer">string need to replace with invalid characters</param>
-        /// <returns>Returns replaced invalid charcters from URL</returns>
+        /// <returns>Returns replaced invalid characters from URL</returns>
         public static string ReplaceInvalidUrlChars(this string content, string replacer)
         {
             return new Regex(INVALID_CHARS_REGEX).Replace(content, replacer);
         }
 
+        /// <summary>
+        /// Encodes URL encoded in a way that SharePoint expected URLs to be encoded in client_LocationBasedDefaults.html
+        /// </summary>
+        /// <param name="content">Url value</param>
+        /// <returns>Returns URL encoded in a way that SharePoint expected URLs to be encoded in client_LocationBasedDefaults.html</returns>
+        public static string UrlPathEncode(this string content)
+        {
+            return System.Web.HttpUtility.UrlPathEncode(content);
+        }
+
         /// <summary>
         /// Tells URL is virtual directory or not
         /// </summary>