Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby warnings #89

Closed
n-rodriguez opened this issue Nov 4, 2021 · 5 comments · Fixed by stereosupersonic/device_detector#1 or #93
Closed

Ruby warnings #89

n-rodriguez opened this issue Nov 4, 2021 · 5 comments · Fixed by stereosupersonic/device_detector#1 or #93

Comments

@n-rodriguez
Copy link
Contributor

n-rodriguez commented Nov 4, 2021 •
edited
Loading

Hi there!

Since release 1.0.6 I get this warning :

/cache/nicolas/concerto/ruby-master/ruby/3.0.0/gems/device_detector-1.0.6/lib/device_detector/parser.rb:88: warning: regular expression has ']' without escape
/cache/nicolas/concerto/ruby-master/ruby/3.0.0/gems/device_detector-1.0.6/lib/device_detector/parser.rb:88: warning: nested repeat operator '+' and '?' was replaced with '*' in regular expression

Thank you!
@n-rodriguez
Copy link
Contributor Author

This PR #88 should help to reveal the warning.

@n-rodriguez n-rodriguez changed the title Ruby 3 warnings Ruby warnings Nov 4, 2021
hendrixfan added a commit to hendrixfan/device_detector that referenced this issue Nov 5, 2021
@hendrixfan
fix(Parser): remove redundant nested repeat operator and escape bracket
5cc442e 
- with ruby 2.7.3 I get the following warnings(described in podigee#89):

```
lib/device_detector/parser.rb:88: warning: regular expression has ']' without escape
lib/device_detector/parser.rb:88: warning: nested repeat operator '+' and '?' was replaced with '*' in regular expression
```
- I removed the '?' operators where possible and exchanged them for '*'
- closes podigee#89
@hendrixfan hendrixfan mentioned this issue Nov 5, 2021
Closed
@Mariusio
Copy link

I wanted to file the same issue. Glad to see that it was already created.

@ryenski ryenski mentioned this issue Nov 22, 2021
Closed
@yakschuss
Copy link

Whoops, looks like I doubled up here

@stereosupersonic stereosupersonic mentioned this issue Jan 27, 2022
Merged
@nickcampbell18 nickcampbell18 mentioned this issue Feb 10, 2022
Closed
@nickcampbell18
Copy link

The regex syntax issues have been resolved upstream: matomo-org/device-detector#6992

Would it be possible to pull the updated files down and cut a new version of this gem please?

@marcelgo
Copy link

Thanks everybody for keeping track and all your efforts. We will provide a newer version of the gem soon.

@spiderpug spiderpug mentioned this issue Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@nickcampbell18 @marcelgo @Mariusio @n-rodriguez @yakschuss