Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definitions and bump to 1.0.7 #93

Merged
merged 7 commits into from
Feb 21, 2022
Merged

Update definitions and bump to 1.0.7 #93

merged 7 commits into from
Feb 21, 2022

Conversation

spiderpug
Copy link
Contributor

Update Matomo Device Detector definitions and updated logic following upstream changes.

Closes #91
Closes #89

@spiderpug spiderpug requested a review from a team February 18, 2022 08:07
girardof
girardof approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@girardof girardof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, it can be deployed as is 💪 .

@spiderpug spiderpug merged commit dee31d7 into develop Feb 21, 2022
@spiderpug spiderpug deleted the update-1.0.7 branch February 21, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girardof girardof girardof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning: nested repeat operator '+' and '?' was replaced with '*' in regular expression Ruby warnings
2 participants
@spiderpug @girardof