.permalink traversal for related taxonomies don't work

[PodsBot]

.permalink traversal for related taxonomies don't work submitted via Slack by josh

[Shelob9]

L795 (in 2.x) looks like where it should pick up the term link. But it doesn't since the conditional that is wrapped in is based on $params->name which has the full value passed for field.

But I think I'm missing something, since that would apply to all .permalink traversals, which work otherwise.

[Shelob9]

It could also get picked up on 1472, but that doesn't get hit because the conditional on 1415 correctly is not passed.

[NikV]

Alright just tested this earlier and confirm it works. Here is how I tested. I created a taxonomy called "tags2". I tested it with echo $pods->display( 'tags2.permalink' ); ($pods being the pods object). The result from this echo was http://local.wordpress.dev/tags2/tag/, which I think would be the proper output for this method. The tags2 taxonomy had only one term assigned to the post.

[Shelob9]

@NikV That's good, but what happens if there are two terms associated with the post? Please report what happens with echo $pods->display( 'tags2.permalink' ); as well as var_dump( echo $pods->field( 'tags2.permalink' ) );

[NikV]

For the echo $pods->display( 'tags2.permalink' );, I only get the first term archive link, not the second one.

[Shelob9]

Sounds like this patch needs more work. What does the var_dump look like?

[NikV]

The var_dump( echo $pods->field( 'tags2.permalink' ) ); outputs this: array(0) { }

[Shelob9]

close via f615242

[sc0ttkclark]

Commit needs revisit

[pglewis]

If you do a var_dump() on just field( 'taxname' ):

array(3) {
  [0]=>
  array(10) {
    ["term_id"]=>
    string(1) "8"
    ["name"]=>
    string(6) "Term 1"
    ["slug"]=>
    string(6) "term-1"
    ["term_group"]=>
    string(1) "0"
    ["term_taxonomy_id"]=>
    string(1) "8"
    ["taxonomy"]=>
    string(12) "multitermtax"
    ["description"]=>
    string(0) ""
    ["parent"]=>
    string(1) "0"
    ["count"]=>
    string(1) "1"
    ["pod_item_id"]=>
    string(1) "8"
  }
  [1]=>
  array(10) {
    ...
  }
}

permalink is not included, thus returning an empty array. field('name') or display('name') works as expected.

[sc0ttkclark]

Merged into 2.x / 3.0, can we close and confirm this issue as fixed? @pglewis @Shelob9

[hotzeplotz]

for info, this may or may not be related, but .permalink traversal for related ACTs had been working correctly for me on a theme i develop until upgrading to Pods 2.5.5 - but 2.5.5. version broke the .permalink traversal for me, somehow. not sure whether it's a distinct bug, and i couldn't find any issue for the ACT behaviour change, so apologies if i'm creating noise here 😏

'fixed' by getting the entire related ACT via $rel = $pod->field('podname') and then using $rel['permalink'], in the meanwhile.

[pglewis]

I've opened #3155 for the regression this has caused.