Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permalink/slug traversal broken for taxonomies in ACTs #3155

Closed
pglewis opened this issue Sep 22, 2015 · 4 comments
Closed

permalink/slug traversal broken for taxonomies in ACTs #3155

pglewis opened this issue Sep 22, 2015 · 4 comments
Assignees
@sc0ttkclark
Labels
Type: Bug
Milestone
Pods 2.6

Comments

@pglewis
Copy link
Contributor

pglewis commented Sep 22, 2015

#2779

c90acb
@pglewis pglewis added this to the Pods 2.5.6 milestone Sep 22, 2015
@pglewis
Copy link
Contributor Author

pglewis commented Sep 22, 2015

Before we patch this, we need to write a failing test since this was not detected by tests.

@pglewis
Copy link
Contributor Author

pglewis commented Sep 22, 2015

Candidate fix here:

elseif ( in_array( $field, array( '_link', 'detail_url' ) ) || ( in_array( $field, array( 'permalink', 'the_permalink' ) ) && 'pod' != $object_type ) )

@pglewis pglewis mentioned this issue Sep 22, 2015
Closed
pglewis referenced this issue Sep 22, 2015
@pglewis
Quick patch, needs a test case and a revisit
1b295a3
@sc0ttkclark sc0ttkclark mentioned this issue Sep 22, 2015
Merged
sc0ttkclark added a commit that referenced this issue Sep 22, 2015
@sc0ttkclark
Add permalink slug field to ACT for testing of #3155 fix
dde6b85
@pglewis
Copy link
Contributor Author

pglewis commented Sep 22, 2015

We have a patch together in the feature/3155 branch that's ready to be tested.

@quasel
Copy link
Member

quasel commented Sep 23, 2015

Did some additional manual Tests e.g
pods('test')->find()->display('related.author.permalink');
pods('test')->find()->display('related.permalink');
pods('test')->find()->display('author.permalink');
pods('test')->find()->display('related.name');

Seems to work fine -

@pglewis pglewis closed this as completed Dec 9, 2015
@sc0ttkclark sc0ttkclark self-assigned this Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc0ttkclark sc0ttkclark

Labels
Type: Bug
Projects
None yet
Milestone
Pods 2.6
Development

No branches or pull requests
3 participants
@sc0ttkclark @pglewis @quasel