Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each Tag Traversal does not work with Taxonomy - Needs some love. #3018

Closed
PodsBot opened this issue Jun 9, 2015 · 5 comments
Closed

Each Tag Traversal does not work with Taxonomy - Needs some love. #3018

PodsBot opened this issue Jun 9, 2015 · 5 comments
Assignees
Milestone

Comments

@PodsBot
Copy link
Collaborator

PodsBot commented Jun 9, 2015

Each Tag Traversal does not work with Taxonomy - Needs some love. submitted via Slack by jimtrue

Related to Forum Post:
http://pods.io/forums/topic/template-each-spits-unexpected-results-on-taxonomy-rel/

This is related to SEVERAL support forum posts, but basically:

  • [each] tag traversal doesn't work with Taxonomy at all. Obviously listing {@taxonomy} does a display array list which is fine, but doesn't give people what they're looking for: links to the taxonomy pages.
  • As a workaround, people have attempted to create relationship fields to Custom Taxonomy and traversing that with the [each] tag. That actually returns a matching entry for EVERY taxonomy term for the number of actual selected taxonomy terms.

My suggestion is we treat Taxonomy as a different animal and treat it differently, either give it it's own style of output tag for traversal or make the each tag recognize that it's traversing a taxonomy.

@jimtrue jimtrue added Type: Bug Type: Enhancement Enhancements to features that already exist, but are not major additions Status: Reproduced labels Jun 9, 2015
@jimtrue jimtrue added this to the Pods 3.1 milestone Jun 9, 2015
@Shelob9
Copy link
Contributor

Shelob9 commented Jun 9, 2015

This is not a template/frontier issue. Pods::find() only gets one associated term, no matter how many terms are associated with the post. That's the actual root issue.

Should probably close as an XY problem.

@jimtrue
Copy link
Contributor

jimtrue commented Jun 9, 2015

Hence why taxonomy handling in template magic tags needs some love. This is feature/enhancement. It doesn't work the way users expect, so we need to give them something that will.

@Shelob9
Copy link
Contributor

Shelob9 commented Jun 9, 2015

It's not a feature/enhancment its a bug in Pod::find() that has nothing to
do with templating. If it worked in Pods::find() then it would work in the
templates

JoshPress.net http://joshpress.net/
CalderaWP.com http://calderawp.com/
@Josh412 http://twitter.com/Josh412

On 9 June 2015 at 16:38, Jim True notifications@github.com wrote:

Hence why taxonomy handling in template magic tags needs some love. This
is feature/enhancement. It doesn't work the way users expect, so we need to
give them something that will.


Reply to this email directly or view it on GitHub
#3018 (comment)
.

@jimtrue
Copy link
Contributor

jimtrue commented Jun 10, 2015

Closed as this is related to open issue #2915 @Shelob9 There was no supporting or related commentary on the other bug so I wasn't aware that was the issue in reference here, I just knew that whatever it was, it didn't get fixed in the last patch set.

@jimtrue jimtrue closed this as completed Jun 10, 2015
@pglewis pglewis removed the Type: Enhancement Enhancements to features that already exist, but are not major additions label Jun 12, 2015
@pglewis
Copy link
Contributor

pglewis commented Aug 18, 2015

I cannot reproduce the described bug in Pods::find() (#2915) so I'm re-opening this one.

@pglewis pglewis reopened this Aug 18, 2015
@pglewis pglewis self-assigned this Aug 18, 2015
pglewis added a commit that referenced this issue Aug 19, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pglewis pglewis assigned sc0ttkclark and unassigned pglewis Aug 19, 2015
@pglewis pglewis modified the milestones: Pods 2.5.5, Pods 3.1 Aug 19, 2015
sc0ttkclark added a commit that referenced this issue Aug 19, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes for #3018, `[each]` tag traversal does not work with taxonomy (2.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants