Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #3018, [each] tag traversal does not work with taxonomy (2.x) #3106

Merged
merged 1 commit into from
Aug 19, 2015

Conversation

pglewis
Copy link
Contributor

@pglewis pglewis commented Aug 19, 2015

2.x branch patch for #3018

Needs review.

@pglewis pglewis added the Patch label Aug 19, 2015
@pglewis pglewis added this to the Pods 2.5.5 milestone Aug 19, 2015
@scrutinizer-notifier
Copy link

A new inspection was created.

@pglewis pglewis changed the title Fixes for #3018, [each] tag traversal does not work with taxonomy Fixes for #3018, [each] tag traversal does not work with taxonomy (2.x) Aug 19, 2015
@sc0ttkclark sc0ttkclark self-assigned this Aug 19, 2015
sc0ttkclark added a commit that referenced this pull request Aug 19, 2015
Fixes for #3018, `[each]` tag traversal does not work with taxonomy (2.x)
@sc0ttkclark sc0ttkclark merged commit 4958ef4 into 2.x Aug 19, 2015
@sc0ttkclark
Copy link
Member

Sorry, merged before I saw that you should be looking at $pod->object_fields and not $pod->fields for taxonomy fields. Can you update the branch and submit a new PR? I'll leave the 3.0 one unmerged for the same reason too.

@sc0ttkclark
Copy link
Member

Let's add a code comment above the field() call that calling field() for a taxonomy object field will populate $pod->fields[ $field_name ] for the object field's data, in this case a taxonomy object field. Without calling $pod->field( $field_name ), it would not normally be available in the $pod->fields array and is something to not expect to be there in 3.0 as this was unintentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants