Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alternate means to detect if running on main thread #946

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Use alternate means to detect if running on main thread #946

merged 1 commit into from
Jan 24, 2025
+36 −12

Conversation

peterkovacs
Copy link
Contributor

This is to avoid problems on linux when running @MainActor tests.

Resolves issue #919

stephencelis
stephencelis approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit eb31d41 into pointfreeco:main Jan 24, 2025
4 checks passed
@groue groue mentioned this pull request Mar 14, 2025
Open
@jcavar jcavar mentioned this pull request Mar 24, 2025
Closed
stephencelis added a commit that referenced this pull request Mar 26, 2025
@stephencelis
Fix regression
2286934 
Unfortunately #946 introduced a deadlock when `assertSnapshot` is called
on the main thread but not the main queue, so let's revert to the old
code path for now with an explicit `Test.current` check to avoid the
original issue.

Fixes #961.
@stephencelis stephencelis mentioned this pull request Mar 26, 2025
Merged
stephencelis added a commit that referenced this pull request Mar 27, 2025
@stephencelis
Fix regression (#962)
dba517b 
Unfortunately #946 introduced a deadlock when `assertSnapshot` is called
on the main thread but not the main queue, so let's revert to the old
code path for now with an explicit `Test.current` check to avoid the
original issue.

Fixes #961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterkovacs @stephencelis