Fix potential deadlock #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcavar Can you please run your tests against this branch? @peterkovacs @doozMen Can you please verify that the original problem is still addressed? |
mbrandonw
approved these changes
Mar 26, 2025
|
I can't recall if it was a crash that would happen with every test run, but I've run with this branch a few dozen times and all runs were successful. |
|
This branch works for me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #946 introduced a deadlock when
assertSnapshotis called on the main thread but not the main queue, so let's revert to the old code path for now with an explicitTest.currentcheck to avoid the original issue.Fixes #961.