Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONSENSUS] Find issue with sending metadata request #548

Merged
merged 21 commits into from
Feb 28, 2023
Merged

[CONSENSUS] Find issue with sending metadata request #548

merged 21 commits into from
Feb 28, 2023

Conversation

gokutheengineer
Copy link
Contributor

@gokutheengineer gokutheengineer commented Feb 25, 2023 •
edited
Loading

Description

Unable to metadata request sending issue on Localnet.

Issue

Fixes #549.

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Fix bug in consensus/debugging.go.

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@gokutheengineer gokutheengineer self-assigned this Feb 25, 2023
@gokutheengineer gokutheengineer added bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes labels Feb 25, 2023
@gokutheengineer gokutheengineer changed the title Fix/statesync metadatareq [BUG] Unable to send metadata request Feb 26, 2023
@gokutheengineer gokutheengineer changed the title [BUG] Unable to send metadata request [CONSENSUS] Unable to send metadata request Feb 26, 2023
@gokutheengineer gokutheengineer changed the title [CONSENSUS] Unable to send metadata request [CONSENSUS] Find issue with sending metadata request Feb 26, 2023
Olshansk
Olshansk approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small issues. PTAL and apply the changes but lgtm otherwise

consensus/state_sync_handler.go Outdated Show resolved Hide resolved
consensus/state_sync_handler.go Outdated Show resolved Hide resolved
consensus/state_sync_handler.go Outdated Show resolved Hide resolved
gokutheengineer and others added 7 commits February 28, 2023 15:57
@gokutheengineer @Olshansk
Update consensus/state_sync_handler.go
ba8644f 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync_handler.go
8ea761c 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync_handler.go
3b0ef61 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer
udpate changelog date
4d8275b
@gokutheengineer
merge
a60139c
@gokutheengineer
Merge branch 'main' into fix/statesync-metadatareq
e9e8433
@gokutheengineer
update
be51293
@gokutheengineer gokutheengineer merged commit 743f6a8 into main Feb 28, 2023
@Olshansk Olshansk deleted the fix/statesync-metadatareq branch February 28, 2023 21:29
bryanchriswhite added a commit that referenced this pull request Mar 1, 2023
@bryanchriswhite
Merge branch 'main' into chore/config
75e529d 
* main:
  [Utility] Foundational bugs, tests, code cleanup and improvements (2/3) (#550)
  [CONSENSUS] Find issue with sending metadata request (#548)
  [Tooling] SLIP-0010 HD Child Key Generation (#510)
bryanchriswhite added a commit that referenced this pull request Mar 3, 2023
@bryanchriswhite
Merge branch 'main' into chore/libp2p-2
d5f33e6 
* main:
  [Libp2p] Add libp2p module directories and helpers (part 1) (#534)
  [P2P, Runtime] Update P2P & base config (part 2) (#535)
  [Utility] Foundational bugs, tests, code cleanup and improvements (2/3) (#550)
  [CONSENSUS] Find issue with sending metadata request (#548)
  [Tooling] SLIP-0010 HD Child Key Generation (#510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@gokutheengineer gokutheengineer

Labels
bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

Successfully merging this pull request may close these issues.

[CONSENSUS] Unable to send state sync metadata request
3 participants
@gokutheengineer @Olshansk @deblasis